From: Jiri Slaby <jirislaby@kernel.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] tty: serial: introduce transmit helper generators
Date: Fri, 2 Sep 2022 07:16:58 +0200 [thread overview]
Message-ID: <e122fe60-484b-fd50-d166-4a21e08d4775@kernel.org> (raw)
In-Reply-To: <YxCkqmz32qMAZAPh@kroah.com>
On 01. 09. 22, 14:25, Greg KH wrote:
> Much nicer, but:
>
>> +#define __DEFINE_UART_PORT_TX_HELPER(name, port, ch, tx_ready, put_char, \
>> + tx_done, for_test, for_post, ...) \
>
> Do you really need "port" and "ch" as part of this macro? You always
> set that to the same thing in your patches, so is it really needed?
Not really, just to make obvious that those are the names that can be
used in tx_ready, put_char... I can remove it, if you prefer, of course.
thanks,
--
js
suse labs
next prev parent reply other threads:[~2022-09-02 5:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-01 11:06 [PATCH v2 0/3] tty: TX helpers Jiri Slaby
2022-09-01 11:06 ` [PATCH v2 1/3] tty: serial: introduce transmit helper generators Jiri Slaby
2022-09-01 12:25 ` Greg KH
2022-09-02 5:16 ` Jiri Slaby [this message]
2022-09-02 5:23 ` Greg KH
2022-09-02 8:02 ` Jiri Slaby
2022-09-02 10:22 ` Ilpo Järvinen
2022-09-02 10:24 ` Jiri Slaby
2022-09-01 11:06 ` [PATCH v2 2/3] tty: serial: use DEFINE_UART_PORT_TX_HELPER() Jiri Slaby
2022-09-02 14:21 ` Ilpo Järvinen
2022-09-06 10:50 ` Jiri Slaby
2022-09-01 11:06 ` [PATCH v2 3/3] tty: serial: use DEFINE_UART_PORT_TX_HELPER_LIMITED() Jiri Slaby
2022-09-02 14:56 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e122fe60-484b-fd50-d166-4a21e08d4775@kernel.org \
--to=jirislaby@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox