From: Max Gurtovoy <mgurtovoy@nvidia.com>
To: Imanol <imvalient@protonmail.com>,
shuah@kernel.org, sagi@grimberg.me, jgg@ziepe.ca,
leon@kernel.org
Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] infiniband: iscsi_iser: fix typos in comments
Date: Mon, 17 Feb 2025 02:27:59 +0200 [thread overview]
Message-ID: <e123e1c9-21d1-4136-a26a-931135c477d3@nvidia.com> (raw)
In-Reply-To: <20250216235602.177904-1-imvalient@protonmail.com>
On 17/02/2025 1:56, Imanol wrote:
> Fixes multiple occurrences of the misspelled word "occured" in the comments
> of `iscsi_iser.c`, replacing them with the correct spelling "occurred".
>
> This improves readability without affecting functionality.
>
> Signed-off-by: Imanol <imvalient@protonmail.com>
> ---
> drivers/infiniband/ulp/iser/iscsi_iser.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/infiniband/ulp/iser/iscsi_iser.c b/drivers/infiniband/ulp/iser/iscsi_iser.c
> index bb9aaff92ca3..a5be6f1ba12b 100644
> --- a/drivers/infiniband/ulp/iser/iscsi_iser.c
> +++ b/drivers/infiniband/ulp/iser/iscsi_iser.c
> @@ -393,10 +393,10 @@ static void iscsi_iser_cleanup_task(struct iscsi_task *task)
> * @task: iscsi task
> * @sector: error sector if exsists (output)
> *
> - * Return: zero if no data-integrity errors have occured
> - * 0x1: data-integrity error occured in the guard-block
> - * 0x2: data-integrity error occured in the reference tag
> - * 0x3: data-integrity error occured in the application tag
> + * Return: zero if no data-integrity errors have occurred
> + * 0x1: data-integrity error occurred in the guard-block
> + * 0x2: data-integrity error occurred in the reference tag
> + * 0x3: data-integrity error occurred in the application tag
> *
> * In addition the error sector is marked.
> */
We usually use: "IB/iser:" prefix in the commit msg subject.
Can you please replace "infiniband: iscsi_iser: fix typos in comments"
with "IB/iser: fix typos in iscsi_iser.c comments" ?
Other than that, looks good.
Acked-by: Max Gurtovoy <mgurtovoy@nvidia.com>
next prev parent reply other threads:[~2025-02-17 0:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-16 23:56 [PATCH] infiniband: iscsi_iser: fix typos in comments Imanol
2025-02-17 0:27 ` Max Gurtovoy [this message]
2025-02-17 18:33 ` Imanol Valiente
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e123e1c9-21d1-4136-a26a-931135c477d3@nvidia.com \
--to=mgurtovoy@nvidia.com \
--cc=imvalient@protonmail.com \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sagi@grimberg.me \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox