public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/2] Add watchdog support for IPQ5424
@ 2024-11-20  5:52 Manikanta Mylavarapu
  2024-11-20  5:52 ` [PATCH 1/2] dt-bindings: watchdog: Document Qualcomm IPQ5424 Manikanta Mylavarapu
  2024-11-20  5:52 ` [PATCH 2/2] arm64: dts: qcom: ipq5424: Add watchdog node Manikanta Mylavarapu
  0 siblings, 2 replies; 6+ messages in thread
From: Manikanta Mylavarapu @ 2024-11-20  5:52 UTC (permalink / raw)
  To: wim, linux, robh, krzk+dt, conor+dt, andersson, konradybcio,
	quic_rjendra, linux-arm-msm, linux-watchdog, devicetree,
	linux-kernel
  Cc: quic_srichara, quic_varada

Add a watchdog node to the IPQ5424 device tree and update the relevant
bindings accordingly.

Manikanta Mylavarapu (2):
  dt-bindings: watchdog: Document Qualcomm IPQ5424
  arm64: dts: qcom: ipq5424: Add watchdog node

 Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml | 1 +
 arch/arm64/boot/dts/qcom/ipq5424.dtsi                    | 7 +++++++
 2 files changed, 8 insertions(+)

-- 
2.34.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/2] dt-bindings: watchdog: Document Qualcomm IPQ5424
  2024-11-20  5:52 [PATCH 0/2] Add watchdog support for IPQ5424 Manikanta Mylavarapu
@ 2024-11-20  5:52 ` Manikanta Mylavarapu
  2024-11-20  7:39   ` Krzysztof Kozlowski
  2024-11-20  5:52 ` [PATCH 2/2] arm64: dts: qcom: ipq5424: Add watchdog node Manikanta Mylavarapu
  1 sibling, 1 reply; 6+ messages in thread
From: Manikanta Mylavarapu @ 2024-11-20  5:52 UTC (permalink / raw)
  To: wim, linux, robh, krzk+dt, conor+dt, andersson, konradybcio,
	quic_rjendra, linux-arm-msm, linux-watchdog, devicetree,
	linux-kernel
  Cc: quic_srichara, quic_varada

Add devicetree binding for watchdog present on Qualcomm IPQ5424 SoC.

Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@quicinc.com>
---
 Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
index 34896a39fa91..49e2b807db0b 100644
--- a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
+++ b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
@@ -20,6 +20,7 @@ properties:
               - qcom,kpss-wdt-ipq4019
               - qcom,apss-wdt-ipq5018
               - qcom,apss-wdt-ipq5332
+              - qcom,apss-wdt-ipq5424
               - qcom,apss-wdt-ipq9574
               - qcom,apss-wdt-msm8226
               - qcom,apss-wdt-msm8974
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/2] arm64: dts: qcom: ipq5424: Add watchdog node
  2024-11-20  5:52 [PATCH 0/2] Add watchdog support for IPQ5424 Manikanta Mylavarapu
  2024-11-20  5:52 ` [PATCH 1/2] dt-bindings: watchdog: Document Qualcomm IPQ5424 Manikanta Mylavarapu
@ 2024-11-20  5:52 ` Manikanta Mylavarapu
  2024-11-20  7:40   ` Krzysztof Kozlowski
  1 sibling, 1 reply; 6+ messages in thread
From: Manikanta Mylavarapu @ 2024-11-20  5:52 UTC (permalink / raw)
  To: wim, linux, robh, krzk+dt, conor+dt, andersson, konradybcio,
	quic_rjendra, linux-arm-msm, linux-watchdog, devicetree,
	linux-kernel
  Cc: quic_srichara, quic_varada

Add the watchdog node for IPQ5424 SoC.

Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@quicinc.com>
---
 arch/arm64/boot/dts/qcom/ipq5424.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/ipq5424.dtsi b/arch/arm64/boot/dts/qcom/ipq5424.dtsi
index 5e219f900412..4ca1ef1c4dc7 100644
--- a/arch/arm64/boot/dts/qcom/ipq5424.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq5424.dtsi
@@ -233,6 +233,13 @@ intc: interrupt-controller@f200000 {
 			msi-controller;
 		};
 
+		watchdog: watchdog@f410000 {
+			compatible = "qcom,apss-wdt-ipq5424", "qcom,kpss-wdt";
+			reg = <0 0x0f410000 0 0x1000>;
+			interrupts = <GIC_SPI 0 IRQ_TYPE_EDGE_RISING>;
+			clocks = <&sleep_clk>;
+		};
+
 		timer@f420000 {
 			compatible = "arm,armv7-timer-mem";
 			reg = <0 0xf420000 0 0x1000>;
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] dt-bindings: watchdog: Document Qualcomm IPQ5424
  2024-11-20  5:52 ` [PATCH 1/2] dt-bindings: watchdog: Document Qualcomm IPQ5424 Manikanta Mylavarapu
@ 2024-11-20  7:39   ` Krzysztof Kozlowski
  0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2024-11-20  7:39 UTC (permalink / raw)
  To: Manikanta Mylavarapu, wim, linux, robh, krzk+dt, conor+dt,
	andersson, konradybcio, quic_rjendra, linux-arm-msm,
	linux-watchdog, devicetree, linux-kernel
  Cc: quic_srichara, quic_varada

On 20/11/2024 06:52, Manikanta Mylavarapu wrote:
> Add devicetree binding for watchdog present on Qualcomm IPQ5424 SoC.
> 
> Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@quicinc.com>
> ---
>  Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml | 1 +
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/2] arm64: dts: qcom: ipq5424: Add watchdog node
  2024-11-20  5:52 ` [PATCH 2/2] arm64: dts: qcom: ipq5424: Add watchdog node Manikanta Mylavarapu
@ 2024-11-20  7:40   ` Krzysztof Kozlowski
  2024-11-20  9:52     ` Manikanta Mylavarapu
  0 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2024-11-20  7:40 UTC (permalink / raw)
  To: Manikanta Mylavarapu, wim, linux, robh, krzk+dt, conor+dt,
	andersson, konradybcio, quic_rjendra, linux-arm-msm,
	linux-watchdog, devicetree, linux-kernel
  Cc: quic_srichara, quic_varada

On 20/11/2024 06:52, Manikanta Mylavarapu wrote:
> Add the watchdog node for IPQ5424 SoC.
> 
> Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@quicinc.com>
> ---
>  arch/arm64/boot/dts/qcom/ipq5424.dtsi | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/ipq5424.dtsi b/arch/arm64/boot/dts/qcom/ipq5424.dtsi
> index 5e219f900412..4ca1ef1c4dc7 100644
> --- a/arch/arm64/boot/dts/qcom/ipq5424.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq5424.dtsi
> @@ -233,6 +233,13 @@ intc: interrupt-controller@f200000 {
>  			msi-controller;
>  		};
>  
> +		watchdog: watchdog@f410000 {
You do not use the label. Can be dropped.

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/2] arm64: dts: qcom: ipq5424: Add watchdog node
  2024-11-20  7:40   ` Krzysztof Kozlowski
@ 2024-11-20  9:52     ` Manikanta Mylavarapu
  0 siblings, 0 replies; 6+ messages in thread
From: Manikanta Mylavarapu @ 2024-11-20  9:52 UTC (permalink / raw)
  To: Krzysztof Kozlowski, wim, linux, robh, krzk+dt, conor+dt,
	andersson, konradybcio, quic_rjendra, linux-arm-msm,
	linux-watchdog, devicetree, linux-kernel
  Cc: quic_srichara, quic_varada



On 11/20/2024 1:10 PM, Krzysztof Kozlowski wrote:
> On 20/11/2024 06:52, Manikanta Mylavarapu wrote:
>> Add the watchdog node for IPQ5424 SoC.
>>
>> Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@quicinc.com>
>> ---
>>  arch/arm64/boot/dts/qcom/ipq5424.dtsi | 7 +++++++
>>  1 file changed, 7 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/ipq5424.dtsi b/arch/arm64/boot/dts/qcom/ipq5424.dtsi
>> index 5e219f900412..4ca1ef1c4dc7 100644
>> --- a/arch/arm64/boot/dts/qcom/ipq5424.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/ipq5424.dtsi
>> @@ -233,6 +233,13 @@ intc: interrupt-controller@f200000 {
>>  			msi-controller;
>>  		};
>>  
>> +		watchdog: watchdog@f410000 {
> You do not use the label. Can be dropped.
> 

Okay, sure. I will drop label.

Thanks & Regards,
Manikanta.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2024-11-20  9:52 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-20  5:52 [PATCH 0/2] Add watchdog support for IPQ5424 Manikanta Mylavarapu
2024-11-20  5:52 ` [PATCH 1/2] dt-bindings: watchdog: Document Qualcomm IPQ5424 Manikanta Mylavarapu
2024-11-20  7:39   ` Krzysztof Kozlowski
2024-11-20  5:52 ` [PATCH 2/2] arm64: dts: qcom: ipq5424: Add watchdog node Manikanta Mylavarapu
2024-11-20  7:40   ` Krzysztof Kozlowski
2024-11-20  9:52     ` Manikanta Mylavarapu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox