From: Mateusz Polchlopek <mateusz.polchlopek@intel.com>
To: "Thomas Weißschuh" <thomas.weissschuh@linutronix.de>,
"David Woodhouse" <dwmw2@infradead.org>,
"Richard Cochran" <richardcochran@gmail.com>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>
Cc: David Woodhouse <dwmw@amazon.co.uk>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <stable@vger.kernel.org>
Subject: Re: [PATCH net-next 0/4] ptp: vmclock: bugfixes and cleanups for error handling
Date: Fri, 7 Feb 2025 08:13:35 +0100 [thread overview]
Message-ID: <e16551dd-3a84-49ba-b875-c11f77239984@intel.com> (raw)
In-Reply-To: <20250206-vmclock-probe-v1-0-17a3ea07be34@linutronix.de>
On 2/6/2025 6:45 PM, Thomas Weißschuh wrote:
> Some error handling issues I noticed while looking at the code.
>
> Only compile-tested.
>
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
> ---
> Thomas Weißschuh (4):
> ptp: vmclock: Set driver data before its usage
> ptp: vmclock: Don't unregister misc device if it was not registered
> ptp: vmclock: Clean up miscdev and ptp clock through devres
> ptp: vmclock: Remove goto-based cleanup logic
>
> drivers/ptp/ptp_vmclock.c | 46 ++++++++++++++++++++--------------------------
> 1 file changed, 20 insertions(+), 26 deletions(-)
> ---
> base-commit: 2014c95afecee3e76ca4a56956a936e23283f05b
> change-id: 20250206-vmclock-probe-57cbcb770925
>
> Best regards,
As those all are fixes and cleanups then I think it should be tagged to
net not net-next.
thanks
next prev parent reply other threads:[~2025-02-07 7:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-06 17:45 [PATCH net-next 0/4] ptp: vmclock: bugfixes and cleanups for error handling Thomas Weißschuh
2025-02-06 17:45 ` [PATCH net-next 1/4] ptp: vmclock: Set driver data before its usage Thomas Weißschuh
2025-02-07 7:07 ` Mateusz Polchlopek
2025-02-06 17:45 ` [PATCH net-next 2/4] ptp: vmclock: Don't unregister misc device if it was not registered Thomas Weißschuh
2025-02-06 17:45 ` [PATCH net-next 3/4] ptp: vmclock: Clean up miscdev and ptp clock through devres Thomas Weißschuh
2025-02-06 17:45 ` [PATCH net-next 4/4] ptp: vmclock: Remove goto-based cleanup logic Thomas Weißschuh
2025-02-07 5:43 ` [PATCH net-next 0/4] ptp: vmclock: bugfixes and cleanups for error handling Richard Cochran
2025-02-07 7:13 ` Mateusz Polchlopek [this message]
2025-02-07 9:10 ` David Woodhouse
2025-02-07 9:25 ` Thomas Weißschuh
2025-02-07 9:29 ` David Woodhouse
2025-02-07 9:13 ` [PATCH net-next 5/4] ptp: vmclock: Add .owner to vmclock_miscdev_fops David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e16551dd-3a84-49ba-b875-c11f77239984@intel.com \
--to=mateusz.polchlopek@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dwmw2@infradead.org \
--cc=dwmw@amazon.co.uk \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=stable@vger.kernel.org \
--cc=thomas.weissschuh@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox