From: Krzysztof Kozlowski <krzk@kernel.org>
To: Marcus Folkesson <marcus.folkesson@gmail.com>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: display: Add Sitronix ST7571 panel
Date: Fri, 4 Apr 2025 19:36:12 +0200 [thread overview]
Message-ID: <e1a7c9d6-9c14-48d3-ac2e-c6e0df04bbbf@kernel.org> (raw)
In-Reply-To: <d2ffca88-6773-4e40-b737-65a451ba1d01@kernel.org>
On 04/04/2025 19:30, Krzysztof Kozlowski wrote:
>> +
>> +examples:
>> + - |
>> + #include <dt-bindings/gpio/gpio.h>
>> +
>> + i2c {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + display@3f {
>
> Not much improved. How is this called in every other binding? panel.
Hmmm, unless this is not a panel, but it looks like a panel and
description partially suggests it. Other sitronix devices are split
between these two, but OTOH your driver is more complex than just simple
panel.
Your commit msg is one sentence and binding description is basically
non-existing, so not sure how to help. You need to describe the hardware
so people understand what this device is.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-04-04 17:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-04 13:50 [PATCH v2 0/3] Add support for Sitronix ST7571 LCD controller Marcus Folkesson
2025-04-04 13:50 ` [PATCH v2 1/3] dt-bindings: display: Add Sitronix ST7571 panel Marcus Folkesson
2025-04-04 16:55 ` Conor Dooley
2025-04-04 17:30 ` Krzysztof Kozlowski
2025-04-04 17:36 ` Krzysztof Kozlowski [this message]
2025-04-04 20:00 ` Marcus Folkesson
2025-04-04 13:50 ` [PATCH v2 2/3] drm/st7571-i2c: add support for Sitronix ST7571 LCD controller Marcus Folkesson
2025-04-07 8:30 ` Thomas Zimmermann
2025-04-07 9:20 ` Marcus Folkesson
2025-04-04 13:50 ` [PATCH v2 3/3] MAINTAINERS: add antry " Marcus Folkesson
2025-04-07 8:31 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1a7c9d6-9c14-48d3-ac2e-c6e0df04bbbf@kernel.org \
--to=krzk@kernel.org \
--cc=airlied@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=marcus.folkesson@gmail.com \
--cc=mripard@kernel.org \
--cc=robh@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox