From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C654C34026 for ; Tue, 18 Feb 2020 16:17:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E773D22527 for ; Tue, 18 Feb 2020 16:17:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="F79v9ten" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726683AbgBRQRw (ORCPT ); Tue, 18 Feb 2020 11:17:52 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:36359 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726422AbgBRQRw (ORCPT ); Tue, 18 Feb 2020 11:17:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582042670; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=M+q/3SoI7jBB7C//HgS1a1L9BZSk3CwgQSLwvdKG4XQ=; b=F79v9ten16z/ev7ifIif2pofCEFS6XE6f1C4fj/sff69XzKOUCPGFG6FC8NAIBbmZhJArY +AGTodfAIR+fWShE9exfFjzRhtaKCEpJAKv/7LFL4QBuw4O5doIrSWoGNqT+Jy67SJVlHp 4k93Y7zvGDwn203rc1Ilgx6EYM/LZwM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-30-xOFPaiX0M5GJPqZ0kAFCxw-1; Tue, 18 Feb 2020 11:17:39 -0500 X-MC-Unique: xOFPaiX0M5GJPqZ0kAFCxw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 00FD610C7F22; Tue, 18 Feb 2020 16:17:37 +0000 (UTC) Received: from prarit.bos.redhat.com (prarit-guest.7a2m.lab.eng.bos.redhat.com [10.16.222.26]) by smtp.corp.redhat.com (Postfix) with ESMTP id DED3660BE1; Tue, 18 Feb 2020 16:17:34 +0000 (UTC) Subject: Re: [PATCH v2] x86/mce: Do not log spurious corrected mce errors To: Borislav Petkov Cc: linux-kernel@vger.kernel.org, Alexander Krupp , Tony Luck , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, linux-edac@vger.kernel.org References: <20200217130659.15895-1-prarit@redhat.com> <20200218161319.GG14449@zn.tnic> From: Prarit Bhargava Message-ID: Date: Tue, 18 Feb 2020 11:17:34 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20200218161319.GG14449@zn.tnic> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/18/20 11:13 AM, Borislav Petkov wrote: > On Mon, Feb 17, 2020 at 08:06:59AM -0500, Prarit Bhargava wrote: >> A user has reported that they are seeing spurious corrected errors on >> their hardware. >> >> Intel Errata HSD131, HSM142, HSW131, and BDM48 report that >> "spurious corrected errors may be logged in the IA32_MC0_STATUS register >> with the valid field (bit 63) set, the uncorrected error field (bit 61) >> not set, a Model Specific Error Code (bits [31:16]) of 0x000F, and >> an MCA Error Code (bits [15:0]) of 0x0005." >> >> Block these spurious errors from the console and logs. >> >> Links to Intel Specification updates: >> HSD131: https://www.intel.com/content/www/us/en/products/docs/processors/core/4th-gen-core-family-desktop-specification-update.html >> HSM142: https://www.intel.com/content/www/us/en/products/docs/processors/core/4th-gen-core-family-mobile-specification-update.html >> HSW131: https://www.intel.com/content/www/us/en/processors/xeon/xeon-e3-1200v3-spec-update.html >> BDM48: https://www.intel.com/content/www/us/en/products/docs/processors/core/5th-gen-core-family-spec-update.html > > My previous review comment still holds: > > Those links tend to get stale with time. If you really want to refer to > the PDFs, add a new bugzilla entry on https://bugzilla.kernel.org/, add > them there as an attachment and add the link to the entry to the commit > message. > >> Signed-off-by: Prarit Bhargava >> Co-developed-by: Alexander Krupp > > WARNING: Co-developed-by: must be immediately followed by Signed-off-by: > #36: > > See Documentation/process/submitting-patches.rst for more detail. > >> Cc: Tony Luck >> Cc: Borislav Petkov >> Cc: Thomas Gleixner >> Cc: Ingo Molnar >> Cc: "H. Peter Anvin" >> Cc: x86@kernel.org >> Cc: linux-edac@vger.kernel.org >> --- >> arch/x86/kernel/cpu/mce/core.c | 2 ++ >> arch/x86/kernel/cpu/mce/intel.c | 17 +++++++++++++++++ >> arch/x86/kernel/cpu/mce/internal.h | 1 + >> 3 files changed, 20 insertions(+) >> >> diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/core.c >> index 2c4f949611e4..fe3983d551cc 100644 >> --- a/arch/x86/kernel/cpu/mce/core.c >> +++ b/arch/x86/kernel/cpu/mce/core.c >> @@ -1877,6 +1877,8 @@ bool filter_mce(struct mce *m) >> { >> if (boot_cpu_data.x86_vendor == X86_VENDOR_AMD) >> return amd_filter_mce(m); >> + if (boot_cpu_data.x86_vendor == X86_VENDOR_INTEL) >> + return intel_filter_mce(m); >> >> return false; >> } >> diff --git a/arch/x86/kernel/cpu/mce/intel.c b/arch/x86/kernel/cpu/mce/intel.c >> index 5627b1091b85..989148e6746c 100644 >> --- a/arch/x86/kernel/cpu/mce/intel.c >> +++ b/arch/x86/kernel/cpu/mce/intel.c >> @@ -520,3 +520,20 @@ void mce_intel_feature_clear(struct cpuinfo_x86 *c) >> { >> intel_clear_lmce(); >> } >> + >> +bool intel_filter_mce(struct mce *m) >> +{ >> + struct cpuinfo_x86 *c = &boot_cpu_data; >> + >> + /* MCE errata HSD131, HSM142, HSW131, BDM48, and HSM142 */ >> + if ((c->x86 == 6) && >> + ((c->x86_model == INTEL_FAM6_HASWELL) || >> + (c->x86_model == INTEL_FAM6_HASWELL_L) || >> + (c->x86_model == INTEL_FAM6_BROADWELL) || >> + (c->x86_model == INTEL_FAM6_HASWELL_G)) && >> + (m->bank == 0) && >> + ((m->status & 0xa0000000ffffffff) == 0x80000000000f0005)) >> + return true; >> + >> + return false; >> +} >> diff --git a/arch/x86/kernel/cpu/mce/internal.h b/arch/x86/kernel/cpu/mce/internal.h >> index b785c0d0b590..821faba5b05d 100644 >> --- a/arch/x86/kernel/cpu/mce/internal.h >> +++ b/arch/x86/kernel/cpu/mce/internal.h >> @@ -175,5 +175,6 @@ extern bool amd_filter_mce(struct mce *m); >> #else >> static inline bool amd_filter_mce(struct mce *m) { return false; }; >> #endif >> +extern bool intel_filter_mce(struct mce *m); > > It doesn't even build: > > ld: arch/x86/kernel/cpu/mce/core.o: in function `filter_mce': > /home/boris/kernel/linux/arch/x86/kernel/cpu/mce/core.c:1881: undefined reference to `intel_filter_mce' > make: *** [Makefile:1077: vmlinux] Error 1 > > Hint: do it like it is done for amd_filter_mce() but in the respective > #ifdef CONFIG_X86_MCE_INTEL place.' That's weird. I just re-compiled it on my system without any issue. Can I have your .config to double check my compile? I'm using the standard fedora config FWIW. P. >