public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Richard Gobert <richardbgobert@gmail.com>
To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, dsahern@kernel.org, shuah@kernel.org,
	liujian56@huawei.com, horms@kernel.org,
	aleksander.lobakin@intel.com, richardbgobert@gmail.com,
	linyunsheng@huawei.com, therbert@google.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-kselftest@vger.kernel.org
Subject: [PATCH net-next 0/3] net: gro: encapsulation bug fix and flush checks improvements
Date: Thu, 22 Feb 2024 22:00:42 +0100	[thread overview]
Message-ID: <e1d22505-c5f8-4c02-a997-64248480338b@gmail.com> (raw)

This series fixes a bug in the complete phase of UDP in GRO, in which
socket lookup fails due to using network_header when parsing encapsulated
packets. The fix is to keep track of both outer and inner offsets.

The last commit leverages the first commit to remove some state from
napi_gro_cb, and stateful code in {ipv6,inet}_gro_receive which may be
unnecessarily complicated due to encapsulation support in GRO.

In addition, udpgro_fwd selftest is adjusted to include the socket lookup
case for vxlan. This selftest will test its supposed functionality once
local bind support is merged (https://lore.kernel.org/netdev/df300a49-7811-4126-a56a-a77100c8841b@gmail.com/).

Richard Gobert (3):
  net: gro: set {inner_,}network_header in receive phase
  selftests/net: add local address bind in vxlan selftest
  net: gro: move L3 flush checks to tcp_gro_receive

 include/net/gro.h                         | 23 ++++---
 net/8021q/vlan_core.c                     |  3 +
 net/core/gro.c                            |  3 -
 net/ipv4/af_inet.c                        | 44 ++------------
 net/ipv4/tcp_offload.c                    | 73 ++++++++++++++++++-----
 net/ipv4/udp_offload.c                    |  2 +-
 net/ipv6/ip6_offload.c                    | 22 ++-----
 net/ipv6/tcpv6_offload.c                  |  2 +-
 net/ipv6/udp_offload.c                    |  2 +-
 tools/testing/selftests/net/udpgro_fwd.sh | 10 +++-
 10 files changed, 97 insertions(+), 87 deletions(-)

-- 
2.36.1

             reply	other threads:[~2024-02-22 21:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-22 21:00 Richard Gobert [this message]
2024-02-22 21:05 ` [PATCH net-next 1/3] net: gro: set {inner_,}network_header in receive phase Richard Gobert
2024-02-22 21:25   ` Eric Dumazet
2024-02-29 13:22     ` Richard Gobert
2024-02-29 20:15       ` Eric Dumazet
2024-03-01 15:02         ` Richard Gobert
2024-02-22 21:07 ` [PATCH net-next 2/3] selftests/net: add local address bind in vxlan selftest Richard Gobert
2024-02-22 21:12 ` [PATCH net-next 3/3] net: gro: move L3 flush checks to tcp_gro_receive Richard Gobert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e1d22505-c5f8-4c02-a997-64248480338b@gmail.com \
    --to=richardbgobert@gmail.com \
    --cc=aleksander.lobakin@intel.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linyunsheng@huawei.com \
    --cc=liujian56@huawei.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=shuah@kernel.org \
    --cc=therbert@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox