From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] nfc: mrvl: use scoped device node handling to simplify cleanup
Date: Fri, 16 Aug 2024 07:11:45 +0200 [thread overview]
Message-ID: <e1dd2de0-2263-4041-b494-70a1b3990143@kernel.org> (raw)
In-Reply-To: <20240815190826.076b7373@kernel.org>
On 16/08/2024 04:08, Jakub Kicinski wrote:
> On Tue, 13 Aug 2024 12:39:04 +0200 Krzysztof Kozlowski wrote:
>> - matched_node = of_get_compatible_child(node, "marvell,nfc-uart");
>> + struct device_node *matched_node __free(device_node) = of_get_compatible_child(node,
>> + "marvell,nfc-uart");
>
> The 100+ character line mixing declaration and code is more than
> I can bear. Sorry.
If by mixing you mean declaration not on top of the code, that's the
preferred style for __free() usage, as expressed by Linus. Constructor
and destructor in one place.
The 100 line, can be solved with wrapping after '=', but of course it is
not particularly pretty.
Let's drop the patch then.
Best regards,
Krzysztof
prev parent reply other threads:[~2024-08-16 5:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-13 10:39 [PATCH net-next] nfc: mrvl: use scoped device node handling to simplify cleanup Krzysztof Kozlowski
2024-08-13 11:53 ` Simon Horman
2024-08-16 2:08 ` Jakub Kicinski
2024-08-16 5:11 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1dd2de0-2263-4041-b494-70a1b3990143@kernel.org \
--to=krzk@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox