From: Vivek Gautam <vivek.gautam@codeaurora.org>
To: Rob Herring <robh@kernel.org>
Cc: joro@8bytes.org, mark.rutland@arm.com, rjw@rjwysocki.net,
gregkh@linuxfoundation.org, robdclark@gmail.com,
will.deacon@arm.com, robin.murphy@arm.com, sboyd@codeaurora.org,
iommu@lists.linux-foundation.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org,
len.brown@intel.com, pavel@ucw.cz, airlied@linux.ie,
sricharan@codeaurora.org, m.szyprowski@samsung.com,
architt@codeaurora.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v5 5/6] iommu/arm-smmu: Add support for qcom,smmu-v2 variant
Date: Fri, 12 Jan 2018 10:59:17 +0530 [thread overview]
Message-ID: <e1ef7c93-aba4-e5e7-bb49-552316274439@codeaurora.org> (raw)
In-Reply-To: <20180111222304.js3c3vrx3u5j3hvj@rob-hp-laptop>
Hi Rob,
On 01/12/2018 03:53 AM, Rob Herring wrote:
> On Tue, Jan 09, 2018 at 03:31:48PM +0530, Vivek Gautam wrote:
>> qcom,smmu-v2 is an arm,smmu-v2 implementation with specific
>> clock and power requirements. This smmu core is used with
>> multiple masters on msm8996, viz. mdss, video, etc.
>> Add bindings for the same.
>>
>> Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org>
>> ---
>>
>> * Major change in this patch -
>> Changed compatible string from 'qcom,msm8996-smmu-v2' to
>> 'qcom,smmu-v2' to reflect the IP version rather than the
>> platform on which it is used.
> The bugs and how things are connected are all the same? I'd suggest you
> keep both strings.
Sure,
compatible = "qcom,msm8996-smmu-v2", "qcom,smmu-v2";
>
>> The same IP is used across multiple platforms including msm8996,
>> and sdm845 etc.
> But for only 2 or so platforms a fallback is not really worth it. You'll
> probably be on SMMUv3 before too long...
Right. There's msm8998 as well, but as you said keeping both strings
will make more sense.
Thanks.
Best regards
Vivek
[snip]
--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2018-01-12 5:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-09 10:01 [PATCH v5 0/6] iommu/arm-smmu: Add runtime pm/sleep support Vivek Gautam
2018-01-09 10:01 ` [PATCH v5 1/6] base: power: runtime: Export pm_runtime_get/put_suppliers Vivek Gautam
2018-01-11 22:53 ` Rafael J. Wysocki
2018-01-12 5:47 ` Vivek Gautam
2018-01-09 10:01 ` [PATCH v5 2/6] iommu/arm-smmu: Add pm_runtime/sleep ops Vivek Gautam
2018-01-09 10:01 ` [PATCH v5 3/6] iommu/arm-smmu: Invoke pm_runtime during probe, add/remove device Vivek Gautam
2018-01-09 10:01 ` [PATCH v5 4/6] iommu/arm-smmu: Add the device_link between masters and smmu Vivek Gautam
2018-01-09 10:01 ` [PATCH v5 5/6] iommu/arm-smmu: Add support for qcom,smmu-v2 variant Vivek Gautam
2018-01-11 22:23 ` Rob Herring
2018-01-12 5:29 ` Vivek Gautam [this message]
2018-01-09 10:01 ` [PATCH v5 6/6] drm/msm: iommu: Replace runtime calls with runtime suppliers Vivek Gautam
2018-01-09 11:23 ` [PATCH v5 0/6] iommu/arm-smmu: Add runtime pm/sleep support Rafael J. Wysocki
2018-01-09 11:49 ` Vivek Gautam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1ef7c93-aba4-e5e7-bb49-552316274439@codeaurora.org \
--to=vivek.gautam@codeaurora.org \
--cc=airlied@linux.ie \
--cc=architt@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=len.brown@intel.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=robdclark@gmail.com \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=sboyd@codeaurora.org \
--cc=sricharan@codeaurora.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox