From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754304AbeALF3e (ORCPT + 1 other); Fri, 12 Jan 2018 00:29:34 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:59902 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753224AbeALF31 (ORCPT ); Fri, 12 Jan 2018 00:29:27 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 3FA116055B Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=vivek.gautam@codeaurora.org Subject: Re: [PATCH v5 5/6] iommu/arm-smmu: Add support for qcom,smmu-v2 variant To: Rob Herring References: <1515492109-753-1-git-send-email-vivek.gautam@codeaurora.org> <1515492109-753-6-git-send-email-vivek.gautam@codeaurora.org> <20180111222304.js3c3vrx3u5j3hvj@rob-hp-laptop> Cc: joro@8bytes.org, mark.rutland@arm.com, rjw@rjwysocki.net, gregkh@linuxfoundation.org, robdclark@gmail.com, will.deacon@arm.com, robin.murphy@arm.com, sboyd@codeaurora.org, iommu@lists.linux-foundation.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, len.brown@intel.com, pavel@ucw.cz, airlied@linux.ie, sricharan@codeaurora.org, m.szyprowski@samsung.com, architt@codeaurora.org, linux-arm-msm@vger.kernel.org From: Vivek Gautam Message-ID: Date: Fri, 12 Jan 2018 10:59:17 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20180111222304.js3c3vrx3u5j3hvj@rob-hp-laptop> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Hi Rob, On 01/12/2018 03:53 AM, Rob Herring wrote: > On Tue, Jan 09, 2018 at 03:31:48PM +0530, Vivek Gautam wrote: >> qcom,smmu-v2 is an arm,smmu-v2 implementation with specific >> clock and power requirements. This smmu core is used with >> multiple masters on msm8996, viz. mdss, video, etc. >> Add bindings for the same. >> >> Signed-off-by: Vivek Gautam >> --- >> >> * Major change in this patch - >> Changed compatible string from 'qcom,msm8996-smmu-v2' to >> 'qcom,smmu-v2' to reflect the IP version rather than the >> platform on which it is used. > The bugs and how things are connected are all the same? I'd suggest you > keep both strings. Sure, compatible = "qcom,msm8996-smmu-v2", "qcom,smmu-v2"; > >> The same IP is used across multiple platforms including msm8996, >> and sdm845 etc. > But for only 2 or so platforms a fallback is not really worth it. You'll > probably be on SMMUv3 before too long... Right. There's msm8998 as well, but as you said keeping both strings will make more sense. Thanks. Best regards Vivek [snip] -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project