From: Markus Elfring <Markus.Elfring@web.de>
To: Tudor Ambarus <tudor.ambarus@linaro.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
Alim Akhtar <alim.akhtar@samsung.com>,
Conor Dooley <conor+dt@kernel.org>,
Jassi Brar <jassisinghbrar@gmail.com>,
Krzysztof Kozlowski <krzk@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
kernel-team@android.com,
"André Draszik" <andre.draszik@linaro.org>,
"Arnd Bergmann" <arnd@arndb.de>,
"Daniel Lezcano" <daniel.lezcano@linaro.org>,
"Peter Griffin" <peter.griffin@linaro.org>,
"Rob Herring" <robh@kernel.org>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
"Vincent Guittot" <vincent.guittot@linaro.org>,
"Will McVicker" <willmcvicker@google.com>
Subject: Re: [PATCH v7 2/3] firmware: add Exynos ACPM protocol driver
Date: Sat, 8 Feb 2025 16:31:00 +0100 [thread overview]
Message-ID: <e1fffd3b-d3dd-4f46-b7b6-1f03f934dd30@web.de> (raw)
In-Reply-To: <20250207-gs101-acpm-v7-2-ffd7b2fb15ae@linaro.org>
…
> +++ b/drivers/firmware/samsung/exynos-acpm.c
> @@ -0,0 +1,771 @@
…
> +static int acpm_dequeue_by_polling(struct acpm_chan *achan,
> + const struct acpm_xfer *xfer)
> +{
…
> + do {
> + mutex_lock(&achan->rx_lock);
> + ret = acpm_get_rx(achan, xfer);
> + mutex_unlock(&achan->rx_lock);
…
Under which circumstances would you become interested to apply a statement
like “guard(mutex)(&achan->rx_lock);”?
https://elixir.bootlin.com/linux/v6.13.1/source/include/linux/mutex.h#L201
Regards,
Markus
next prev parent reply other threads:[~2025-02-08 15:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-07 15:29 [PATCH v7 0/3] firmware: add Exynos ACPM protocol driver Tudor Ambarus
2025-02-07 15:29 ` [PATCH v7 1/3] dt-bindings: firmware: add google,gs101-acpm-ipc Tudor Ambarus
2025-02-07 15:29 ` [PATCH v7 2/3] firmware: add Exynos ACPM protocol driver Tudor Ambarus
2025-02-08 15:00 ` kernel test robot
2025-02-08 15:31 ` Markus Elfring [this message]
2025-02-10 8:59 ` Tudor Ambarus
2025-02-10 9:23 ` Krzysztof Kozlowski
2025-02-11 8:40 ` Tudor Ambarus
2025-02-07 15:29 ` [PATCH v7 3/3] MAINTAINERS: add entry for the Samsung Exynos ACPM mailbox protocol Tudor Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1fffd3b-d3dd-4f46-b7b6-1f03f934dd30@web.de \
--to=markus.elfring@web.de \
--cc=alim.akhtar@samsung.com \
--cc=andre.draszik@linaro.org \
--cc=arnd@arndb.de \
--cc=conor+dt@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jassisinghbrar@gmail.com \
--cc=kernel-team@android.com \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=peter.griffin@linaro.org \
--cc=robh@kernel.org \
--cc=tudor.ambarus@linaro.org \
--cc=ulf.hansson@linaro.org \
--cc=vincent.guittot@linaro.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox