From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B769C43334 for ; Tue, 28 Jun 2022 12:55:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346005AbiF1Mzk (ORCPT ); Tue, 28 Jun 2022 08:55:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49262 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345995AbiF1Mze (ORCPT ); Tue, 28 Jun 2022 08:55:34 -0400 Received: from out2.migadu.com (out2.migadu.com [IPv6:2001:41d0:2:aacc::]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 345DE2F39A for ; Tue, 28 Jun 2022 05:55:33 -0700 (PDT) Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1656420931; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mqAG6NtuPeXXT/iyoPFvKD2DWm9Jh7e8oexC24YjANo=; b=JppEkjCyCOm7jL3qbB/qIlKo/Ny7szXdrp5BiRkHoo7g9tt/HVC3/+2Ua/h1/dEEMiDk5G GXWSHNvPaVj2lYes5quE+T4r5wIt/zUC4j4HUgMZ+zzK+ReON1jee0ET5c00Sn2te7xwSx iRZWGfNPsQKGuvAsmnFDzrfsOuGgrXg= Date: Tue, 28 Jun 2022 15:55:29 +0300 MIME-Version: 1.0 Subject: Re: [PATCH v3 1/1] Create debugfs file with virtio balloon usage information Content-Language: en-US To: Alexander Atanasov , "Michael S. Tsirkin" , David Hildenbrand , Jason Wang Cc: kernel@openvz.org, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org References: <20220627163714-mutt-send-email-mst@kernel.org> <20220628092324.23656-1-alexander.atanasov@virtuozzo.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Vasily Averin In-Reply-To: <20220628092324.23656-1-alexander.atanasov@virtuozzo.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/28/22 12:23, Alexander Atanasov wrote: > +static int virtio_balloon_debug_show(struct seq_file *f, void *offset) > +{ > + struct virtio_balloon *b = f->private; > + u32 num_pages; > + struct sysinfo i; > + > + si_meminfo(&i); > + > + seq_printf(f, "%-22s: %d\n", "page_size", 4096); This output of the constant looks strange for me. Could you please explain why this is required? Thank you, Vasily Averin