From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B09F3364E9E for ; Tue, 13 Jan 2026 06:43:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768286627; cv=none; b=pyhwcIdsdzNqfH92xhBb3wV7bTVRhoNMY07DB37yZlk2G2z3UxXaEjaOKyMCG3Z4j/4tbkYwZulZUFPjuqbsAof0mbQ6Lnr/9HodH1FDku+Dz3pBmOhTqtmudTWvV8MHG5mlGmVds5QnazbCXTaHBQHaCF9aAql4hloh4iaLKwo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768286627; c=relaxed/simple; bh=4xRp9EmzMV7UevZ0sWEkDBOodR/UA5X1qgUIvoNC9pQ=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=kv19tc5EkYLXWooawWrJWQv5m3cxBDhhx9BCtFNheiRJNuMIfRkpeapO+12+y7hFNeAsA+Ckqoa6vx+fxVkSok6n7dCbuQhGQ97CeLehPTOv8lrYA1W3JZNoOqnYvGsGj17q1St2iJFXAxPmZq+rkf470EVm8k+eB4peGzn+ung= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mlqznh0K; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mlqznh0K" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-4327778df7fso4493320f8f.3 for ; Mon, 12 Jan 2026 22:43:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768286624; x=1768891424; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=ghDCM8N9hxvDdm5XEm74/ukNIOPEjRNuq6UPBRaEC88=; b=mlqznh0KAmc2HekvQQUM75RbUjXLgwKRtqyFu60L1W1iK2cI1m6WdjgRE8NbDcuOux GAbpmKYMDi0zOzCFH/oEkvMEml9+A3iG9nMffG6b/3fVhNJN7JazjMtHO31i0MQLGnfQ /2nemnnh7Qa+Cs/3rciDVlP5tw0kW6IYXNmNs9Y9ZSIZy1iur3JVIgzuwCjj1OYLc9ob 6B2WGt78puBqtMzzEfEKWHyzHfbN6mo1UDTLQ3RxCJaW9ZZTxGe7pfukIL9+hvY1wn1M 2s8Em6Ux8utqmH6jZvMPciWRjmEKqp4H0JxORveQ3mzcD90XG5hdCbLFaDjgIHXvYlos IMQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768286624; x=1768891424; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ghDCM8N9hxvDdm5XEm74/ukNIOPEjRNuq6UPBRaEC88=; b=LnxRZYNrYQyEdNLBiaeDj8PmUsAITm4YtdkhC87/p8lTtg0XfWrM6L1OpWcfMN6K5t 0buezbHvZeTjoYGQb1FYRIdFWmINiPKRYI+ZkUdKVaNbU7zQJ0Oh2qwiZRbwefqjWQBk GDge937d0AA4SxBQCyAbv0idZNZWqLR5Z8CEnQg/E6Ad7HKpFD2rk9HQBtursHcgv1bU LD6EQ1pAIPb3t4u3BJLUk3M+BrlAYoJbl4QoKia/x0Zbojw42aEj0UcVh815xQVTLjb/ 4jUuOkfcKYAa+fhqNs2JSCd8BKvXZrGMWitbmWUklh3NGs9UMbRH7sZN3kAwpkDNqHMY Wc6g== X-Forwarded-Encrypted: i=1; AJvYcCWqZWGqHoFOw2orQlEYnpC5FLlhIlfGy8qTHn/NBKJnlzybzgW4jGfcryT6fvRlFUk8hMNbbDMNA4qJgW4=@vger.kernel.org X-Gm-Message-State: AOJu0YyOyHobiyi/5GysmT1rYrw7oMVEAK9EA1p1Vg0BMuaKvkiU1ESy jyytzclzfzrfW5deq7kqIuMK1oTbVTN+XSVnKZZNnePK9gSIScQ7Kfd8 X-Gm-Gg: AY/fxX6QHk+v6THLhhAJt3NrMwuqOkiuAEQ472diX1yKWC7tAqkCFcZhEIstC/W7I7u GDV7zK4DFc09q/QNiwiCbXv3Gm2QLL3FqCyMN9dIZPmuyi+FSTD/LozYYTAx4K5ngBCcyq20YQq zMxxuAhlz4mNj35O21+GakZQuce3Hx+LLU63Y2hZlvl1oLTDE7soFp1i+C/ZKmXYYbd26ZQKax1 dhfN1lT6yqn2DLpnC1gLXwjzqPMJ0cpePnR9tOIWuHmX4YniF+YK5pN21upGljKyuXeGzK/xT+G I0aYq08OeErg3RJcX/1D3waQEdmLLFP43Cd5txah8d4t8yRrw86RuZaSeszgjEyp1bpPUUUG5kC n1vBzCslLVkorAVTRx/AElJH21AhX9eHOTa6sOxnK2oPRluTT5xP4AvFkKnbgN+HV6+0eIQ/u3X 2rHQZ1vGuQP3MQd31KMCfPVRsVmUFj7f5Hrq0= X-Google-Smtp-Source: AGHT+IG5Hg9+17m7J4fNxlH62AWH3o6AAFlmU1pJNtsSLShz7avFHksvTJHxAOMxOVStty2IwBs58g== X-Received: by 2002:a05:6000:178a:b0:430:f449:5f18 with SMTP id ffacd0b85a97d-432c37644b4mr25992646f8f.46.1768286623960; Mon, 12 Jan 2026 22:43:43 -0800 (PST) Received: from [10.221.200.118] ([165.85.126.46]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd5df90dsm42594086f8f.20.2026.01.12.22.43.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Jan 2026 22:43:43 -0800 (PST) Message-ID: Date: Tue, 13 Jan 2026 08:43:42 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC mlx5-next 0/1] net/mlx5e: Expose physical received bits counters to ethtool From: Tariq Toukan To: Kenta Akagi , Saeed Mahameed , Tariq Toukan , Mark Bloch , Leon Romanovsky , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260112070324.38819-1-k@mgml.me> <0ac69f6a-d587-45a7-be30-6ad4429ef8d2@gmail.com> Content-Language: en-US In-Reply-To: <0ac69f6a-d587-45a7-be30-6ad4429ef8d2@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 13/01/2026 8:31, Tariq Toukan wrote: > > > On 12/01/2026 9:03, Kenta Akagi wrote: >> Hi, >> >> I would like to measure the cable BER on ConnectX. >> >> According to the documentation[1][2], there are counters that can be used >> for this purpose: rx_corrected_bits_phy, rx_pcs_symbol_err_phy and >> rx_bits_phy. However, rx_bits_phy does not show up in ethtool >> statistics. >> >> This patch exposes the PPCNT phy_received_bits as rx_bits_phy. >> >> >> On a ConnectX-5 with 25Gbase connection, it works as expected. >> >> On the other hand, although I have not verified it, in an 800Gbps >> environment rx_bits_phy would likely overflow after about 124 days. >> Since I cannot judge whether this is acceptable, I am posting this as an >> RFC first. >> > > Hi, > > This is a 64-bits counter so no overflow is expected. > Sorry, ignore my comment, your numbers make sense. Maybe it's ~248 days, but same idea. >> >> [1] commit 8ce3b586faa4 ("net/mlx5: Add counter information to mlx5 >>      driver documentation") >> [2] https://docs.kernel.org/networking/device_drivers/ethernet/ >> mellanox/mlx5/counters.html >> >> Kenta Akagi (1): >>    net/mlx5e: Expose physical received bits counters to ethtool >> >>   drivers/net/ethernet/mellanox/mlx5/core/en_stats.c | 1 + >>   1 file changed, 1 insertion(+) >> >