From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54209C04AB1 for ; Mon, 13 May 2019 06:44:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 25EED2146F for ; Mon, 13 May 2019 06:44:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727549AbfEMGos (ORCPT ); Mon, 13 May 2019 02:44:48 -0400 Received: from mga18.intel.com ([134.134.136.126]:12748 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726103AbfEMGos (ORCPT ); Mon, 13 May 2019 02:44:48 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 May 2019 23:44:47 -0700 X-ExtLoop1: 1 Received: from ahunter-desktop.fi.intel.com (HELO [10.237.72.198]) ([10.237.72.198]) by orsmga002.jf.intel.com with ESMTP; 12 May 2019 23:44:45 -0700 Subject: Re: [RFC PATCH 2/2] mmc: sdhci: Quirk for AMD SDHC Device 0x7906 To: "S-k, Shyam-sundar" , Raul E Rangel , "linux-mmc@vger.kernel.org" , "Agrawal, Nitesh-kumar" Cc: "djkurtz@chromium.org" , "linux-kernel@vger.kernel.org" , Ulf Hansson , "Sen, Pankaj" , "Shah, Nehal-bakulchandra" References: <20190501175457.195855-1-rrangel@chromium.org> <20190501175457.195855-2-rrangel@chromium.org> <08c3dc49-f5cb-401d-b900-12879f469728@intel.com> <495b70a3-0232-343b-9081-56869415986f@amd.com> From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: Date: Mon, 13 May 2019 09:44:36 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <495b70a3-0232-343b-9081-56869415986f@amd.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/05/19 8:04 PM, S-k, Shyam-sundar wrote: > On 5/2/2019 12:02 PM, Adrian Hunter wrote: >> Cc: some AMD people >> >> On 1/05/19 8:54 PM, Raul E Rangel wrote: >>> AMD SDHC 0x7906 requires a hard reset to clear all internal state. >>> Otherwise it can get into a bad state where the DATA lines are always >>> read as zeros. >>> >>> This change requires firmware that can transition the device into >>> D3Cold for it to work correctly. If the firmware does not support >>> transitioning to D3Cold then the power state transitions are a no-op. >>> >>> Signed-off-by: Raul E Rangel > Signed-off-by: Shyam Sundar S K > Acked-by: Adrian Hunter