The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: "Chen, Yu C" <yu.c.chen@intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: "Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	"Hans de Goede" <hansg@kernel.org>,
	"Linux ACPI" <linux-acpi@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	"Maximilian Luz" <luzmaximilian@gmail.com>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	platform-driver-x86@vger.kernel.org,
	"chen.yu@linux.dev" <chen.yu@linux.dev>
Subject: Re: [PATCH v1] platform/surface: surfacepro3_button: Stop setting acpi_device_name()
Date: Mon, 6 Jul 2026 23:32:11 +0800	[thread overview]
Message-ID: <e23b39d1-e305-4ef9-b35d-29d9d1019835@intel.com> (raw)
In-Reply-To: <6036011.DvuYhMxLoT@rafael.j.wysocki>

On 7/6/2026 8:28 PM, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> Since acpi_device_name() set by the driver is only used for input
> class device name initialization and printing a message on probe
> success, and SURFACE_BUTTON_DEVICE_NAME can be used instead of it
> directly in both cases, make the driver do so and stop setting
> acpi_device_name().
> 
> No intentional functional impact.
> 
> This will facilitate the removal of device_name from struct
> acpi_device_pnp in the future.
> 
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---

I have not noticed any issues,
(sashiko reported an invalid and unrelated to this patch race of UAF,
which should be gated by evdev->mutex)

Reviewed-by: Chen Yu <yu.c.chen@intel.com>

thanks,
Chenyu

  reply	other threads:[~2026-07-06 15:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-06 12:28 [PATCH v1] platform/surface: surfacepro3_button: Stop setting acpi_device_name() Rafael J. Wysocki
2026-07-06 15:32 ` Chen, Yu C [this message]
2026-07-06 15:46 ` Andy Shevchenko
2026-07-06 16:06   ` Rafael J. Wysocki (Intel)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e23b39d1-e305-4ef9-b35d-29d9d1019835@intel.com \
    --to=yu.c.chen@intel.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=chen.yu@linux.dev \
    --cc=hansg@kernel.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luzmaximilian@gmail.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox