From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751273AbdJWJBc (ORCPT <rfc822;w@1wt.eu>);
        Mon, 23 Oct 2017 05:01:32 -0400
Received: from mout.web.de ([212.227.15.3]:65102 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751113AbdJWJBb (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 23 Oct 2017 05:01:31 -0400
Subject: Re: um: Use common error handling code in port_listen_fd()
To: Dan Carpenter <dan.carpenter@oracle.com>,
        user-mode-linux-devel@lists.sourceforge.net
Cc: Jeff Dike <jdike@addtoit.com>, Richard Weinberger <richard@nod.at>,
        user-mode-linux-user@lists.sourceforge.net,
        kernel-janitors@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
References: <b16407cf-0caa-ea1d-7997-0e9a231468f3@users.sourceforge.net>
 <20171023084800.p26qcpb7iqyqrz4v@mwanda>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <e248c905-eb76-d9bd-6e10-92be8b200590@users.sourceforge.net>
Date: Mon, 23 Oct 2017 11:01:05 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <20171023084800.p26qcpb7iqyqrz4v@mwanda>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:gJdqu/lZspAwGIqVYajEuutT8JlzE9/NWbd8aUkKaPvpC59mW8p
 fPoWeEpu0gjiOeZkpaN0qcXiHfz9HUN+Elf6NhCK8d7Qq5lS+FfmXpwe1QXXxaIJ/4lOzBQ
 QPECmcXcAjno9EKlbwN3XYKs/bEmD7Cns2ag1R9Gqb7JZuJCpWCEUZqTGmkbjIv4ipLJIkH
 CFjfHP7Hnatb+ppRqSWKA==
X-UI-Out-Filterresults: notjunk:1;V01:K0:eQ+VlJO87ok=:ZEKnpR7aRgy6NBSJhVBquv
 mIc2mSgkl371UvqXa6aGpWHUn3b9EUqzAJjCImuZrrnTljyZd2+g7O9cbeYlvIayAmRr6P6jX
 uLAkDxOcBhQzgVlnu23EBoEUSO1DIpJWgdDHQrF+VSU58WWnbr3IpcpiWWueBzZMp3IeLqH1N
 sLSk6K4PMu15ikQ4M+u0mLFIJdeCVXV2hw3dHPHFic8z+TKTEFA9ACtbZjySO+PQJcS6mDHFz
 cj7vy4fQu18owUPs35019w0zHSjyIqmqGawd4MPhSLiGLCwgADQTufaq2cwVopBXnhCr+AFMF
 Fh48qv7icSihDPgR0JYWdpG7A4YR5A9arN137ofukqmYCA4NzctfQRoqdohiy3J5BZx4NGa9i
 j7KIxr3YCUPBvSchnqgFEACq5RqmHaSLZOnUv3JGY2YFxW5Cccn6UBEEP+1s/gYJSNVnw1SHW
 eP21cA3O+A0vOzLcOyMo8pkaCHEhgp0z9dmTf4VfLcKWZ+sIDup7r+6/kQp97VBI+UBeWwgp+
 iaxTm6+NMPmwo43Q9f576cr/p6vhpMNENKhQkB5ebXQrEGcq8KbpYajHjI5nZnSjgzHSBh9I8
 7kWl394JJqDCQ41hC8VxrQ3mqGG8bFe4B46JFgXMbKInDcSLzSkjod6YKZFGAr32MaKkJtKmz
 4Ki7BQAk7oPBCDheAj5B3wqOoxvFC6SD8HkqRWYUPX82YWqvNX8uNzQ6I0LQ3CsLuLzTjH4kd
 NuTjiUVsUJWapaz4+f5MdVoAKXns7RNicwiMKMtLC15AohcpWrkfudItdTtRVmasGKhQQoLgv
 CEzMnXYYz6brqDwJ6utWJZ7bnZmHOOqjmQNyFGUQStyZFBUFlE=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> This business of moving the error code to the bottom of the function
> just makes the code less readable.

I got an other software development opinion on this aspect.
Could you become used to the proposed control flow structure
in the affected function?


> I know you never listen to anyone,

My response times might not fir to your preferences.


> but you should stop doing it.

I am going to offer suggestions for change patterns which I find useful.
There are some challenges around change acceptance as usual.

Regards,
Markus