Re: [PATCH 1/2] tty/serial: Sort drivers in makefile

["Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1106 bytes --]

On Wed, 13 Sep 2023, Jiri Slaby wrote:

> On 12. 09. 23, 12:35, Ilpo Järvinen wrote:
> > Sort drivers in alphabetic order in Makefile to make it easier to find
> > the correct line. In case the CONFIG and filenames disagree, sort using
> > the filename (but ignoring "serial" prefixes).
> 
> Overall looks good.
> 
> I just want to make sure you considered the below, as you don't say explicitly
> in the commit log.
> 
> The order in the makefile defines the link order. So built-in drivers are
> loaded in that order. So are you sure your patch doesn't change order of some
> drivers which need to be in a specific order?

Thanks for taking a look.

I limited the ordering to non-library like "leaf" driver files so it 
should be safe. Except for 8250_early that was in middle of drivers so
I moved it before the driver section but that doesn't alter anything 
important AFAICT.

In any case, I double-checked this again and only thing I found out is 
that for some reason SERIAL_8250_EXAR depends on 8250_PCI but nothing uses 
the 4 functions 8250_pci.c EXPORTs (which I'll address shortly).


-- 
 i.