From: Damien Le Moal <dlemoal@kernel.org>
To: John Garry <john.g.garry@oracle.com>,
jejb@linux.ibm.com, martin.petersen@oracle.com,
chenxiang66@hisilicon.com, artur.paszkiewicz@intel.com,
yanaijie@huawei.com, jinpu.wang@cloud.ionos.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 10/10] scsi: libsas: Delete sas_ata_task.retry_count
Date: Tue, 15 Aug 2023 11:14:19 +0900 [thread overview]
Message-ID: <e26abff8-ec52-2663-057b-fbefc3b818dd@kernel.org> (raw)
In-Reply-To: <20230814141022.36875-11-john.g.garry@oracle.com>
On 8/14/23 23:10, John Garry wrote:
> Since libsas was introduced in commit 2908d778ab3e ("[SCSI] aic94xx: new
> driver"), sas_ata_task.retry_count is never set, so delete it and the
> reference in asd_build_ata_ascb().
>
> Signed-off-by: John Garry <john.g.garry@oracle.com>
Looks good.
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2023-08-15 2:15 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-14 14:10 [PATCH 00/10] libsas: Some tidy-up John Garry
2023-08-14 14:10 ` [PATCH 01/10] scsi: libsas: Delete sas_ha_struct.lldd_module John Garry
2023-08-15 2:07 ` Damien Le Moal
2023-08-15 9:27 ` Jason Yan
2023-10-09 6:38 ` Hannes Reinecke
2023-08-14 14:10 ` [PATCH 02/10] scsi: libsas: Delete enum sas_class John Garry
2023-08-15 2:07 ` Damien Le Moal
2023-08-15 9:30 ` Jason Yan
2023-10-09 6:38 ` Hannes Reinecke
2023-08-14 14:10 ` [PATCH 03/10] scsi: libsas: Delete enum sas_phy_type John Garry
2023-08-15 2:08 ` Damien Le Moal
2023-08-15 9:30 ` Jason Yan
2023-10-09 6:39 ` Hannes Reinecke
2023-08-14 14:10 ` [PATCH 04/10] scsi: libsas: Delete struct scsi_core John Garry
2023-08-15 2:10 ` Damien Le Moal
2023-08-15 9:30 ` Jason Yan
2023-10-09 6:40 ` Hannes Reinecke
2023-08-14 14:10 ` [PATCH 05/10] scsi: libsas: Delete sas_ssp_task.retry_count John Garry
2023-08-15 2:10 ` Damien Le Moal
2023-08-15 9:31 ` Jason Yan
2023-10-09 6:41 ` Hannes Reinecke
2023-08-14 14:10 ` [PATCH 06/10] scsi: libsas: Delete sas_ssp_task.enable_first_burst John Garry
2023-08-15 2:11 ` Damien Le Moal
2023-08-15 9:34 ` Jason Yan
2023-10-09 6:42 ` Hannes Reinecke
2023-08-14 14:10 ` [PATCH 07/10] scsi: libsas: Delete sas_ssp_task.task_prio John Garry
2023-08-15 2:17 ` Damien Le Moal
2023-08-15 7:44 ` John Garry
2023-10-09 6:55 ` Hannes Reinecke
2023-10-24 10:07 ` John Garry
2023-10-24 10:08 ` Hannes Reinecke
2023-08-14 14:10 ` [PATCH 08/10] scsi: libsas: Delete sas_ata_task.set_affil_pol John Garry
2023-08-15 2:12 ` Damien Le Moal
2023-08-15 9:37 ` Jason Yan
2023-10-09 6:56 ` Hannes Reinecke
2023-08-14 14:10 ` [PATCH 09/10] scsi: libsas: Delete sas_ata_task.stp_affil_pol John Garry
2023-08-15 2:13 ` Damien Le Moal
2023-08-15 9:37 ` Jason Yan
2023-10-09 6:57 ` Hannes Reinecke
2023-08-14 14:10 ` [PATCH 10/10] scsi: libsas: Delete sas_ata_task.retry_count John Garry
2023-08-15 2:14 ` Damien Le Moal [this message]
2023-08-15 9:37 ` Jason Yan
2023-10-09 6:57 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e26abff8-ec52-2663-057b-fbefc3b818dd@kernel.org \
--to=dlemoal@kernel.org \
--cc=artur.paszkiewicz@intel.com \
--cc=chenxiang66@hisilicon.com \
--cc=jejb@linux.ibm.com \
--cc=jinpu.wang@cloud.ionos.com \
--cc=john.g.garry@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=yanaijie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox