Re: [PATCH V3 2/2] scripts: dtc: Build fdtoverlay and fdtdump tools

Frank Rowand
2021-01-12T18:35:32Z

On 1/11/21 11:08 PM, Viresh Kumar wrote:
> On 11-01-21, 18:44, Frank Rowand wrote:
>> On 1/7/21 12:25 AM, Viresh Kumar wrote:
>>> We will start building overlays for platforms soon in the kernel and
>>> would need these tools going forward. Lets start building them.
>>>
>>> The fdtoverlay program applies (or merges) one ore more overlay dtb
>>> blobs to a base dtb blob. The kernel build system would later use
>>> fdtoverlay to generate the overlaid blobs based on platform specific
>>> configurations.
>>>
>>> The fdtdump program prints a readable version of a flat device-tree
>>> file. This is a very useful tool to analyze the details of the overlay's
>>> dtb and the final dtb produced by fdtoverlay after applying the
>>> overlay's dtb to a base dtb.
>>
>> You can calso dump an FDT with:
>>
>> dtc -O dts XXX.dtb
>>
>> Is this sufficient for the desired functionality, or is there something
>> additional in fdtdump that is needed?
>

comment 1:

> Not for my usecase at least.

>
>> If nothing additional needed, and there is no other justification for adding
>> another program, I would prefer to leave fdtdump out.
>

comment 2:

> Okay, then I will also remove the stale version of fdtdump which is
> already there in kernel since a long time.
>

I'm confused. I read comment 1 as saying that fdtdump does provide a feature
that you need to analyze the dtb created by fdtoverlay. But I read comment 2
as implying that you are accepting that fdtdump will not be added to the
Linux kernel source.

-Frank