From: Chao Yu <chao@kernel.org>
To: Jingbo Xu <jefflexu@linux.alibaba.com>,
xiang@kernel.org, huyue2@coolpad.com,
linux-erofs@lists.ozlabs.org
Cc: zhujia.zj@bytedance.com, yinxin.x@bytedance.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] erofs: get correct count for unmapped range in fscache mode
Date: Tue, 8 Nov 2022 11:09:29 +0800 [thread overview]
Message-ID: <e288944b-559c-e184-96c4-370a80cbb9a9@kernel.org> (raw)
In-Reply-To: <20221104054028.52208-3-jefflexu@linux.alibaba.com>
On 2022/11/4 13:40, Jingbo Xu wrote:
> For unmapped range, the returned map.m_llen is zero, and thus the
> calculated count is unexpected zero.
>
> Prior to the refactoring introduced by commit 1ae9470c3e14 ("erofs:
> clean up .read_folio() and .readahead() in fscache mode"), only the
> readahead routine suffers from this. With the refactoring of making
> .read_folio() and .readahead() calling one common routine, both
> read_folio and readahead have this issue now.
>
> Fix this by calculating count separately in unmapped condition.
>
> Fixes: c665b394b9e8 ("erofs: implement fscache-based data readahead")
> Fixes: 1ae9470c3e14 ("erofs: clean up .read_folio() and .readahead() in fscache mode")
> Signed-off-by: Jingbo Xu <jefflexu@linux.alibaba.com>
Reviewed-by: Chao Yu <chao@kernel.org>
Thanks,
prev parent reply other threads:[~2022-11-08 3:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-04 5:40 [PATCH 0/2] erofs: misc fixes for erofs in fscache mode Jingbo Xu
2022-11-04 5:40 ` [PATCH 1/2] erofs: put metabuf in error path " Jingbo Xu
2022-11-04 10:03 ` Gao Xiang
2022-11-07 14:41 ` [External] " Jia Zhu
2022-11-08 3:07 ` Chao Yu
2022-11-04 5:40 ` [PATCH 2/2] erofs: get correct count for unmapped range " Jingbo Xu
2022-11-04 10:03 ` Gao Xiang
2022-11-08 3:09 ` Chao Yu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e288944b-559c-e184-96c4-370a80cbb9a9@kernel.org \
--to=chao@kernel.org \
--cc=huyue2@coolpad.com \
--cc=jefflexu@linux.alibaba.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xiang@kernel.org \
--cc=yinxin.x@bytedance.com \
--cc=zhujia.zj@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox