From: Krzysztof Kozlowski <krzk@kernel.org>
To: Konstantin Pugin <ria.freelander@gmail.com>
Cc: conor@kernel.org, lkp@intel.com, vz@mleia.com, robh@kernel.org,
jcmvbkbc@gmail.com, nicolas.ferre@microchip.com,
manikanta.guntupalli@amd.com, corbet@lwn.net,
ychuang3@nuvoton.com, u.kleine-koenig@pengutronix.de,
Maarten.Brock@sttls.nl,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Hugo Villeneuve" <hvilleneuve@dimonoff.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Lech Perczak" <lech.perczak@camlingroup.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH v7 0/3] add support for EXAR XR20M1172 UART
Date: Mon, 22 Apr 2024 15:45:26 +0200 [thread overview]
Message-ID: <e2989aa1-7f2b-4ac3-8fd8-822c87d61a1e@kernel.org> (raw)
In-Reply-To: <20240422133219.2710061-1-ria.freelander@gmail.com>
On 22/04/2024 15:32, Konstantin Pugin wrote:
> EXAR XR20M1172 UART is mostly SC16IS762-compatible, but
> it has additional register which can change UART multiplier
> to 4x and 8x, similar to UPF_MAGIC_MULTIPLIER does. So, I used this
> flag to guard access to its specific DLD register. It seems than
> other EXAR SPI UART modules also have this register, but I tested
> only XR20M1172.
> Yes, in datasheet this register is called "DLD - Divisor Fractional"
> or "DLD - Divisor Fractional Register", calling depends on datasheet
> version.
>
> I am sorry about too many submissions and top post reply. About second -
> I do not know how to reply properly to this ML from GMail phone app. About first - I just
> get very good feedback from Andy Shevchenko, and want to fix his review picks ASAP.
>
One patchset per 24h.
Plus, you already got such review comment:
This is a friendly reminder during the review process.
It looks like you received a tag and forgot to add it.
If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new
versions, under or above your Signed-off-by tag. Tag is "received", when
provided in a message replied to you on the mailing list. Tools like b4
can help here. However, there's no need to repost patches *only* to add
the tags. The upstream maintainer will do that for tags received on the
version they apply.
https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577
If a tag was not added on purpose, please state why and what changed.
Just start using b4.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-04-22 13:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 13:32 [PATCH v7 0/3] add support for EXAR XR20M1172 UART Konstantin Pugin
2024-04-22 13:32 ` [PATCH v7 1/3] serial: sc16is7xx: announce support of SER_RS485_RTS_ON_SEND Konstantin Pugin
2024-04-23 18:59 ` Hugo Villeneuve
2024-04-22 13:32 ` [PATCH v7 2/3] dt-bindings: sc16is7xx: Add compatible line for XR20M1172 UART Konstantin Pugin
2024-04-22 15:28 ` Conor Dooley
2024-04-22 15:31 ` Konstantin P.
2024-04-22 13:32 ` [PATCH v7 3/3] serial: sc16is7xx: add support for EXAR " Konstantin Pugin
2024-04-23 17:28 ` Hugo Villeneuve
2024-04-23 17:32 ` Konstantin P.
2024-04-22 13:45 ` Krzysztof Kozlowski [this message]
2024-04-22 13:50 ` [PATCH v7 0/3] " Konstantin P.
2024-04-22 13:51 ` Krzysztof Kozlowski
[not found] ` <CAF1WSuzzzG_vm5b55zb_ha-Vj7H+i3ZbmPyN1F-EQxS3GLaurg@mail.gmail.com>
2024-04-22 14:42 ` Hugo Villeneuve
2024-04-22 14:43 ` Andy Shevchenko
2024-04-22 14:57 ` Konstantin P.
2024-04-23 12:54 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2989aa1-7f2b-4ac3-8fd8-822c87d61a1e@kernel.org \
--to=krzk@kernel.org \
--cc=Maarten.Brock@sttls.nl \
--cc=andy@kernel.org \
--cc=conor@kernel.org \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=hvilleneuve@dimonoff.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jcmvbkbc@gmail.com \
--cc=jirislaby@kernel.org \
--cc=lech.perczak@camlingroup.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lkp@intel.com \
--cc=manikanta.guntupalli@amd.com \
--cc=nicolas.ferre@microchip.com \
--cc=ria.freelander@gmail.com \
--cc=robh@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vz@mleia.com \
--cc=ychuang3@nuvoton.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox