public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: make_ruc2021@163.com, linux-spi@vger.kernel.org,
	Aaro Koskinen <aaro.koskinen@nokia.com>,
	Mark Brown <broonie@kernel.org>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] spi: fix reference leak in spi_register_controller()
Date: Tue, 17 Dec 2024 13:16:30 +0100	[thread overview]
Message-ID: <e29d221e-4ecc-41a8-9cfa-268c45ec9bdb@web.de> (raw)
In-Reply-To: <20241217073133.2908052-1-make_ruc2021@163.com>

> Once device_add() failed, we should call put_device() to decrement
> reference count for cleanup. Or it could cause memory leak.

Is there a need to integrate the added function call better into
a goto chain?

Regards,
Markus

  reply	other threads:[~2024-12-17 12:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-17  7:31 [PATCH] spi: fix reference leak in spi_register_controller() Ma Ke
2024-12-17 12:16 ` Markus Elfring [this message]
2024-12-17 15:23 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e29d221e-4ecc-41a8-9cfa-268c45ec9bdb@web.de \
    --to=markus.elfring@web.de \
    --cc=aaro.koskinen@nokia.com \
    --cc=broonie@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=make_ruc2021@163.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox