From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1882329A5 for ; Wed, 15 Jan 2025 06:10:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736921409; cv=none; b=p+mrxEaZ14AlbNUKgJpvp0Y3pBprxge9QfFJJ8cFzDGzbllgdPJHVScNYzw1axQhnEDjl/NDtEJm/Gbe/WnarekAd9ocxg8ed83YeTryIeV/G4X8IQNpegW6BWJEEhlmc7oaQjNkAgzgNNL1jBJgSI8AcE5kvqnWXPqNd8uesjw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736921409; c=relaxed/simple; bh=I8QjCiFdn6fue3Z2B0YpsHrA6t0QvRCDVIdgvi0jL+g=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=G3oRAhyFt2CfzGQ7WD71Ur9ADJLsQMSYqqvujG43YlE00tdr7NstnPU2WsJtwFkHNmDv/IWDPI2NUz/jmEY8JdpXkz9gS+spKh6nHgm/7r1yv1SyeDjy/nVtribWqFZFXYLKLIjy0JJOh1DO/C41PTruRzu2uP49sfYUXLPL1oc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UbBECwy2; arc=none smtp.client-ip=209.85.208.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UbBECwy2" Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-5d3f57582a2so1062152a12.1 for ; Tue, 14 Jan 2025 22:10:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736921405; x=1737526205; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xdjUWXMpCuGTyhpaGbaUHH2q6d5HqfhmCxI2osIrDFE=; b=UbBECwy2ydJ5vJk7Z8ziCFZNAuWYfMflNujmjzVj8fCyehhh92GBoaDVpqjyEh9tvl adzQRJ1v0RfibWx+ZFSbwW3zATQ34wcKB31XpIZbLZNJKgq/NhYtQ5eLH915LAhTi7fW MUadN+0tiW76YXmKgcetIrlSTsdVvZKdh7i1L5+E+mDg5qPf6N653S+Ooh/2QYX/bIay oepZCe/GcYghXlu7C/dXDhvlvEEA7lwZ4S/P26CacdZYjje7HkaXP5ZCSk2RL4diW8Gh 7Ok1pZS7TKfFlVploFQwlO0tQdluACHmqPyUOYaXIWwDfobXWvaOqWtuO43+5a+859iF 2CBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736921405; x=1737526205; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xdjUWXMpCuGTyhpaGbaUHH2q6d5HqfhmCxI2osIrDFE=; b=MHE7WYrmI5cY7PprcIN6YeQIXcdROsOpMkm5U3IsOjBtLHqDxRPppFQ9Jtaflnkc+c RQSDRAWitrdiv4Eswz10+BReUhuAr/OhMsuAAPS0CYVUzKmceIVMrW1Z/yoBE1v6aC7K ckpUWMHyUOfDvI5JiNw4a31E+igW/paWZne5raNo8gLir02pOFpUmvVpx9EEXf7Rks7H PTWOsjjUDWWos4QdaaD4PI5c84EJPDFwEqIph8hUdzz0gjkjokiUPuWjiXSoiwDhHbrz N7ddeWkzQpCBFjDbdWS+RdBSM3cQRvFXRYrOoyhE657WiXNxYrCQinK8JUjggcA1PTD7 1W4Q== X-Forwarded-Encrypted: i=1; AJvYcCV6ObRuBHnJGHN4ERJCHGAAXZ9EYeiahV9KyeiIXwE5yLmzrujjurEN6r4RWgzJmZ5nPeety0Crg6AaedY=@vger.kernel.org X-Gm-Message-State: AOJu0Ywgh/gQGEER9JNJCIrWzz/cgDBYucgFfRLtavr0TQU2RwCnAs8M 68R8NhlH4isNNt6S5gsHYIqM57x2CrwGj1LNjM24f5AFqr2I3anr X-Gm-Gg: ASbGnctxtUAWWfxpKH8EL+x2yh+RdDkf63SGGJCrKhf4SBlKYW6WL0kUrQnsw7rMbxO CCdfDuZ416V4nfoNxFbpRgvqj8l9k+w8dMKvKkpYS9FCKUkOFt8WofPsEHeUIKHnS/7qEyfuieo rwWh+9y4bf3ulyCV3RujqyE1Mav2hRm7BQ0xIMUIxe7K24Q/MsmkLSsSxAEBZK+aKqg2TcqwAxr q0rdKnsXXq5rgX5X46COpzPabczkUiwdRzPVRrpAclisZZ/e+fY1IElGw4LFjCyZbRdJQ== X-Google-Smtp-Source: AGHT+IF1qX0sohkzQNYygxvcTY4ghAIHYfUuxS0V98Bx3zv5ZoKf8Y8yDgyz+5+cURy2NIFhXVKBEw== X-Received: by 2002:a05:6402:358f:b0:5d0:f6ed:4cd1 with SMTP id 4fb4d7f45d1cf-5da0c2efefemr1539937a12.10.1736921405004; Tue, 14 Jan 2025 22:10:05 -0800 (PST) Received: from [192.168.1.10] ([95.43.220.235]) by smtp.googlemail.com with ESMTPSA id 4fb4d7f45d1cf-5d99008c394sm7071443a12.7.2025.01.14.22.10.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Jan 2025 22:10:04 -0800 (PST) Message-ID: Date: Wed, 15 Jan 2025 08:10:03 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH] soc: audio-graph-card2: use correct endpoint when getting link parameters To: Kuninori Morimoto Cc: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, tony@atomide.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org References: <20241220071126.1066691-1-ivo.g.dimitrov.75@gmail.com> <87y0zdsxme.wl-kuninori.morimoto.gx@renesas.com> <98a19395-7056-48d1-ad89-fb057025f46c@gmail.com> <875xmhj6s0.wl-kuninori.morimoto.gx@renesas.com> Content-Language: en-GB From: Ivaylo Dimitrov In-Reply-To: <875xmhj6s0.wl-kuninori.morimoto.gx@renesas.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Morimoto-san, On 15.01.25 г. 1:49 ч., Kuninori Morimoto wrote: > > Hi Ivaylo > > Thank you for clarify your situation. > >>> You want to parse "remote" endpoint (= rep) directly, but the function >>> requests "port" (= rport), and it will use endpoint0 ( != rep). >>> Is this the main issue you want to fix ? >>> >> >> Yes, it is the 'remote' side endpoint, currently it is always remote >> endpoint0 that is used, because when you get 'port', it is endpoint0 of >> that port that core uses. > > OK, I could understand, and I can agree to your idea. > Getting "port" from "endpoint" is always stable, but getting "endpoint" > from "port" without parameter will be issue, indeed. > > But I guess your original patch is based on very old kernel ? > It can't be applied to Mark's for-6.14 branch as-is. > Please based on latest branch. > Yes, it is based in 6.6, that's why I sent RFC patch, as rebasing will not be trivial and I didn't want to spend time on something that could possibly be rejected. > And about git-comment, > > When link parameters are parsed, it is always endpoint@0 that is used and > parameters set to other endpoints are ignored. > > Please indicate that current function requests "port" as parameter, > thus, it always selects endpoint0, etc. That is easy to understand. > Ok, will do. Thanks! Ivo