From: Andrew Lunn <andrew@lunn.ch>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
David Jander <david@protonic.nl>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2 3/3] net: phy: dp83tg720: switch to adaptive polling and remove random delays
Date: Thu, 12 Jun 2025 17:34:55 +0200 [thread overview]
Message-ID: <e2e91c7e-c201-4fbc-9e5e-e967b6c52e8b@lunn.ch> (raw)
In-Reply-To: <20250612104157.2262058-4-o.rempel@pengutronix.de>
On Thu, Jun 12, 2025 at 12:41:57PM +0200, Oleksij Rempel wrote:
> From: David Jander <david@protonic.nl>
>
> Now that the PHY reset logic includes a role-specific asymmetric delay
> to avoid synchronized reset deadlocks, the previously used randomized
> polling intervals are no longer necessary.
>
> This patch removes the get_random_u32_below()-based logic and introduces
> an adaptive polling strategy:
> - Fast polling for a short time after link-down
> - Slow polling if the link remains down
> - Slower polling when the link is up
>
> This balances CPU usage and responsiveness while avoiding reset
> collisions. Additionally, the driver still relies on polling for
> all link state changes, as interrupt support is not implemented,
> and link-up events are not reliably signaled by the PHY.
>
> The polling parameters are now documented in the updated top-of-file
> comment.
>
> Co-developed-by: Oleksij Rempel <o.rempel@pengutronix.de>
> Signed-off-by: David Jander <david@protonic.nl>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2025-06-12 15:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-12 10:41 [PATCH net-next v2 0/3] dp83tg720: Reduce link recovery Oleksij Rempel
2025-06-12 10:41 ` [PATCH net-next v2 1/3] net: phy: dp83tg720: implement soft reset with asymmetric delay Oleksij Rempel
2025-06-12 15:33 ` Andrew Lunn
2025-06-12 10:41 ` [PATCH net-next v2 2/3] net: phy: dp83tg720: remove redundant 600ms post-reset delay Oleksij Rempel
2025-06-12 15:34 ` Andrew Lunn
2025-06-12 10:41 ` [PATCH net-next v2 3/3] net: phy: dp83tg720: switch to adaptive polling and remove random delays Oleksij Rempel
2025-06-12 15:34 ` Andrew Lunn [this message]
2025-06-14 1:20 ` [PATCH net-next v2 0/3] dp83tg720: Reduce link recovery patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2e91c7e-c201-4fbc-9e5e-e967b6c52e8b@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=david@protonic.nl \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox