From: Wyes Karny <wyes.karny@amd.com>
To: Dave Hansen <dave.hansen@intel.com>, linux-kernel@vger.kernel.org
Cc: Lewis.Carroll@amd.com, Mario.Limonciello@amd.com,
gautham.shenoy@amd.com, Ananth.Narayan@amd.com, bharata@amd.com,
len.brown@intel.com, x86@kernel.org, tglx@linutronix.de,
mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
hpa@zytor.com, peterz@infradead.org, chang.seok.bae@intel.com,
keescook@chromium.org, metze@samba.org,
zhengqi.arch@bytedance.com, mark.rutland@arm.com, puwen@hygon.cn,
rafael.j.wysocki@intel.com, andrew.cooper3@citrix.com,
jing2.liu@intel.com, jmattson@google.com,
pawan.kumar.gupta@linux.intel.com
Subject: Re: [PATCH v2 3/3] x86: Fix comment for X86_FEATURE_ZEN
Date: Fri, 6 May 2022 00:25:28 +0530 [thread overview]
Message-ID: <e2eef6eb-30eb-8d18-a24a-a66c5023302f@amd.com> (raw)
In-Reply-To: <ce377229-06ee-7f68-ca55-361a8986a7e7@intel.com>
Hello Dave,
On 5/5/2022 10:40 PM, Dave Hansen wrote:
> On 5/5/22 04:04, Wyes Karny wrote:
>> The feature X86_FEATURE_ZEN implies that the CPU supports Zen
>> microarchitecture. Call this out explicitly in the comment.
>
> Is "supports" the best word here?
>
> A CPU is based on a microarchitecture, it doesn't really support it. I
> guess we could say the CPU supports a microarchitecture's *features*,
> but that's a bit wordy for a tiny comment.
>
> Maybe:
>
> #define X86_FEATURE_ZEN (7*32+28) /* "" CPU based on Zen uarch */
Thank you, Dave. Yes, "based on" could be a better choice here. I'll update this.
>
> or spell out "microarchitecture" if there's room.
Thanks,
Wyes
prev parent reply other threads:[~2022-05-05 18:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-05 10:48 [PATCH v2 0/3] x86: Prefer MWAIT over HALT on AMD processors Wyes Karny
2022-05-05 10:48 ` [PATCH v2 1/3] x86: Use HALT in default_idle when idle=nomwait cmdline arg is passed Wyes Karny
2022-05-05 17:13 ` Dave Hansen
2022-05-06 11:23 ` Wyes Karny
2022-05-05 11:01 ` [PATCH v2 2/3] x86: Remove vendor checks from prefer_mwait_c1_over_halt Wyes Karny
2022-05-05 17:04 ` Dave Hansen
2022-05-06 9:42 ` Wyes Karny
2022-05-06 15:52 ` Dave Hansen
2022-05-06 18:19 ` Wyes Karny
2022-05-05 11:04 ` [PATCH v2 3/3] x86: Fix comment for X86_FEATURE_ZEN Wyes Karny
2022-05-05 17:10 ` Dave Hansen
2022-05-05 18:55 ` Wyes Karny [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2eef6eb-30eb-8d18-a24a-a66c5023302f@amd.com \
--to=wyes.karny@amd.com \
--cc=Ananth.Narayan@amd.com \
--cc=Lewis.Carroll@amd.com \
--cc=Mario.Limonciello@amd.com \
--cc=andrew.cooper3@citrix.com \
--cc=bharata@amd.com \
--cc=bp@alien8.de \
--cc=chang.seok.bae@intel.com \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=gautham.shenoy@amd.com \
--cc=hpa@zytor.com \
--cc=jing2.liu@intel.com \
--cc=jmattson@google.com \
--cc=keescook@chromium.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=metze@samba.org \
--cc=mingo@redhat.com \
--cc=pawan.kumar.gupta@linux.intel.com \
--cc=peterz@infradead.org \
--cc=puwen@hygon.cn \
--cc=rafael.j.wysocki@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=zhengqi.arch@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox