From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1034777AbcIZMw4 (ORCPT ); Mon, 26 Sep 2016 08:52:56 -0400 Received: from mout.web.de ([212.227.15.3]:63039 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030456AbcIZMwy (ORCPT ); Mon, 26 Sep 2016 08:52:54 -0400 Subject: Re: [PATCH 5/5] ISDN-CAPI: Delete unnecessary braces To: Paul Bolle References: <06e7637c-f682-bfa2-82b6-47d071bd58c4@users.sourceforge.net> <52dd5000-2bda-a1b6-aa97-1868e1193d35@cogentembedded.com> <727b14d4-7a3b-9de8-25d9-c3bf212f7c44@users.sourceforge.net> <1474881642.1846.14.camel@tiscali.nl> Cc: Sergei Shtylyov , netdev@vger.kernel.org, Karsten Keil , LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: Date: Mon, 26 Sep 2016 14:52:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1474881642.1846.14.camel@tiscali.nl> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:98FuUuUFaWTNQ+uafpXtzPthdORCnrkZTdCc/SZQBMAC5RsIGT5 hpHDVomW3bGf0Oe63BBLTc0ByLkbt5RLmPn/IijY6iQdqCQIng+GFuDARl5247f8uxtpBLQ T3AbhBzRFDHY5PAtdIzct85tEYqqtkrEaDEHbPaMKC6vMg8azBRrEO74sis1DgShWmSK2Or m10SXZ7L7xJ3n1QLA4c3w== X-UI-Out-Filterresults: notjunk:1;V01:K0:yBZsDnoJMQQ=:2FFy6gtk7u//pvFxiASFQ/ Xk9sm0fu4xdUTpNrUejvTtnC7S3Phd4YAM3h14CAbHxAafBs5bMfzhMejfKKp9yVeqijHPPWO bFWiN2wb4VUR8fwvzmFDn7Y0mo0gUJIIN3AzWcnAOhfWIkl5BgtdjFiKPNVI9QOVb0TjMbO+d apeJWWIqqXh3qvmyqPGbLKqPrXnuwiRnmhimplMESiKAtnbrWbTeRqjrq8e6EhR8ZQXj6FiHD xIbgn0ygj3T1jcdyWcZq7bHyHYbvlWsGUsQvmXjQjpWaa+QJxWCXZJIrW6lCWQktIPLvTV9Vn Wj8+7dtEgGbUV7Jb8J7NF7siiGeKnqByt1bH0KjVrYYtWq88GJPo1Gl5X//6ArqiQCf9Ea2bJ aw9flE5YuH0O6YOAIDYzQ61XtCqwkbdyYkMW0BW1spudcXRjbajoeZA4s/cS9b9tcq27QtFh4 iTkqnMmdP/DrKACGaziBmNk5VGxnWqmwTHL3PcXss4wtTrCxd3kT0PlO854iB77GBT5MWNarI OyWBpW8TqVyAedVInB+JsbROWyVnBvEyHvZNnaRWIOAXIvI/+1HHrf/3HFHV6OpnvZNu+t27w xq83QGyrEkiSVXhzOahEf4sqIDb1+EaRHaOBe78kQn5NY3/jicH+cA7KtOsjREpz54QTMQ8In +C7y79IE0GkRcYV31AjHoaEe1Twuo0kUCrSpgtbMNWqVkHGfsV26B2Npedv4Vy+mCpIS3Tmcj 0iB46aNHVOZh2OLTS4CSsvdniO/9iReOS2jScAQwirGLxJyz2fS22ZZRcr/4Sfh2xsRah9X4D NHc5adg Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>>> @@ -976,13 +974,12 @@ static void handle_controller(_cmsg *cmsg) >>>> if (debugmode) >>>> printk(KERN_DEBUG "capidrv-%d: listenconf Info=0x%4x >>>> (%s) cipmask=0x%x\n", >>>> card->contrnr, cmsg->Info, >>>> capi_info2str(cmsg->Info), card->cipmask); >>>> - if (cmsg->Info) { >>>> + if (cmsg->Info) >>>> listen_change_state(card, EV_LISTEN_CONF_ERROR); >>>> - } else if (card->cipmask == 0) { >>>> + else if (card->cipmask == 0) >>>> listen_change_state(card, EV_LISTEN_CONF_EMPTY); >>>> - } else { >>>> + else >>> >>> Indented too much. >> >> How do you think about an alignment of this "else" >> with the corresponding if statement three lines above? > > Well, I think it looks silly. Thanks for your feedback. > checkpatch apparently agrees: > WARNING: Statements should start on a tabstop > #51: FILE: drivers/isdn/capi/capidrv.c:981: > + else > > total: 0 errors, 1 warnings, 91 lines checked … > You use checkpatch a lot, don't you? It seems so when I am preparing hundreds of update steps. > Didn't you use it to, you know, check your patch? This Perl script showed me also the quoted information. I dared to present a deviation from this general advice because I got the mood to gather constructive comments on source code formatting also around an if statement like in my update suggestion. Would it eventually make sense to move this "if" (behind an "else") to a separate line and increase the indentation for the corresponding code one level then? Regards, Markus