From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752131AbdJ3IFB (ORCPT ); Mon, 30 Oct 2017 04:05:01 -0400 Received: from mout.web.de ([217.72.192.78]:56594 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751417AbdJ3IE7 (ORCPT ); Mon, 30 Oct 2017 04:04:59 -0400 Subject: Re: IB/mlx4: Use common error handling code in __mlx4_ib_create_flow() To: Leon Romanovsky , Dennis Dalessandro , Doug Ledford , linux-rdma@vger.kernel.org Cc: Hal Rosenstock , Sean Hefty , Yishai Hadas , Yuval Shaia , LKML , kernel-janitors@vger.kernel.org References: <0bcea3cf-91e3-01d5-8d80-34cd6b611fb1@users.sourceforge.net> <70843f43-03c5-8295-643a-4f228ff2e907@intel.com> <0c92fc8e-ecb8-c7ed-0b4c-721752297222@users.sourceforge.net> <20171027193601.GI16127@mtr-leonro.local> From: SF Markus Elfring Message-ID: Date: Mon, 30 Oct 2017 09:04:36 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171027193601.GI16127@mtr-leonro.local> Content-Type: text/plain; charset=windows-1252 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:lhAoPN4B9f/byuuRJLaz57e5EeN/SFUp4pkGUaAL3By291ODysN EbgZ9ReSIp+SXav83h2iyh/UKd4ttutlH5qjbfXlaVZY+2BniQqSh0fly85CJjZHV427LTO dD3qpLjzwvRRzzk4bPX3BJyIVwUUisArgzkpMhB+e6INaYxLx6WzumkBWQ4wDd0LFq+z/Vm f1IMNUhlijatp8hnvChmQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:RJK1AHFX+Nw=:CwizRLsrAf4P1BhOZK2SLD 2wMjpOQKyVbyhLtJksukV5QmNIjeXGJn0ovc6vsSpqGZAd1MbVd2YclToMVqNjG68T0fr0OMY NemTd0D8ZlFzXCHMVB5hCxq/Yss6OAyd0KshKujmxejUBalibFNnUTUeBkAsw9EtM338nlOea ylgWjqAwaiqCD1NLkyhuvHUXDb8amBKMlbK5kok+k5GI5bl5BCrkrg1Q9I+eCq5CX9uMOe0bg 3w30iDtr0LE/hGdPLFGHOKHuZYoHMm9x7rjfDPe8b1oF5GNKWc++o2BIruLIGf+5KOvVg7N7Z TE9J8dRwB+6PmVzMxsNV0M4GZ43herR+Auup8Kcx7g8lZ1MisHbtxyXmVDEJIy5VvmBn/bVY5 ed8gLd/ys2mG6dKqShcFbsJMNetydqXquO3m4gosjbwmJW4gu3lTU/WE2OmF4epRChya+agIv eJpclfCDWniJ9wUONhd2wHm/YNmTTYwhKX+DQ0EecS+WGVcXwGHq6jXJnzG9GJV/uOoZjZa2k 4jALPPBd3QHDBsykW45ni2ethNuq2cGmbCtoPWW5OKz/MGrlTzYQdkWe9Lm4fhWwH/mYKv1uq csRoQk5VGbzo4FfqUXYggduVcHP84ANBwjBN/Z1nWzmQr2b++05gjDIu1A6qaLhRXxAESk4iH CaLFUx2GlXaOGY+nsPPcn+d8ZrHv6fifNqIiVYBggHcqzblG6Qz1eSo1yo8pWL82NBSdPX+Kz jYe0J8nRS+kOELyBQdUqHz25cgT3WbtbpS5E5bB4EuzeiyrSAhD5ughz+3w5KBiAUHu3oHQge uq+t1C5Hg27AP87dRoTR/SeTBtSDDQkTa+CsP7SSY19RjxGRR0= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>> I mean you aren't really making the code any smaller >> >> Would anybody like to check corresponding effects in more detail >> after a specific function call was replaced by a goto statement? > > You are supposed to do it and not "anybody". I can offer another bit of information for this software development discussion. The following build settings were active in my “Makefile” for this Linux test case. … HOSTCFLAGS = -Wall -Wmissing-prototypes -Wstrict-prototypes -O0 -fomit-frame-pointer -std=gnu89 … The affected source file can be compiled for the processor architecture “x86_64” by a tool like “GCC 6.4.1+r251631-1.3” from the software distribution “openSUSE Tumbleweed” with the following command example. my_cc=/usr/bin/gcc-6 \ && my_module=drivers/infiniband/hw/mlx4/main.o \ && git checkout next-20171009 \ && make -j4 CC="${my_cc}" HOSTCC="${my_cc}" allmodconfig "${my_module}" \ && size "${my_module}" \ && git checkout next_fine-tuning_in_mlx4_1 \ && make -j4 CC="${my_cc}" HOSTCC="${my_cc}" allmodconfig "${my_module}" \ && size "${my_module}" Do you find the following details useful for further clarification? text: -32 data: 0 bss: 0 Regards, Markus