From: Jiri Slaby <jirislaby@kernel.org>
To: Xianting Tian <xianting.tian@linux.alibaba.com>,
gregkh@linuxfoundation.org, amit@kernel.org, arnd@arndb.de,
osandov@fb.com
Cc: shile.zhang@linux.alibaba.com, sfr@canb.auug.org.au,
linuxppc-dev@lists.ozlabs.org,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v12 1/2] tty: hvc: pass DMA capable memory to put_chars()
Date: Wed, 10 Nov 2021 10:50:40 +0100 [thread overview]
Message-ID: <e2ff335d-5d21-345f-d899-8985477ffa53@kernel.org> (raw)
In-Reply-To: <7dde342a-c2b7-32fe-7410-e372c82a4a68@linux.alibaba.com>
On 04. 11. 21, 14:06, Xianting Tian wrote:
>> OTOH, you need c[N_OUTBUF] in the console case (hvc_console_print), but
>> not whole hvc_struct. So cons_hvcs should be an array of structs
>> composed of only the lock and the buffer.
> It is ok for me.
>> =============
>>
>> And I would do it even simpler now. One c[N_OUTBUF] buffer for all
>> consoles and a single lock.
>>
>> And "char c" in struct hvc_struct.
>>
>> No need for the complex logic in hvc_console_print.
>
> So you will implement this?
No, there is a slight difference between "I would" and "I will" :). I
don't have anything to test this hvc change on…
thanks,
--
js
suse labs
next prev parent reply other threads:[~2021-11-10 9:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-28 15:09 [PATCH v12 0/2] make hvc pass dma capable memory to its backend Xianting Tian
2021-10-28 15:09 ` [PATCH v12 1/2] tty: hvc: pass DMA capable memory to put_chars() Xianting Tian
2021-11-02 6:33 ` Jiri Slaby
2021-11-04 13:06 ` Xianting Tian
2021-11-10 9:50 ` Jiri Slaby [this message]
2021-10-28 15:09 ` [PATCH v12 2/2] virtio-console: remove unnecessary kmemdup() Xianting Tian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2ff335d-5d21-345f-d899-8985477ffa53@kernel.org \
--to=jirislaby@kernel.org \
--cc=amit@kernel.org \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=osandov@fb.com \
--cc=sfr@canb.auug.org.au \
--cc=shile.zhang@linux.alibaba.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xianting.tian@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox