From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Naresh Solanki <naresh.solanki@9elements.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Lee Jones <lee@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Patrick Rudolph <patrick.rudolph@9elements.com>
Cc: Marcello Sylvester Bauer <sylv@sylv.io>
Subject: Re: [PATCH v6 1/2] dt-bindings: mfd: Add bindings for MAX5970 and MAX5978
Date: Thu, 3 Nov 2022 16:26:21 -0400 [thread overview]
Message-ID: <e3164343-3b0d-6672-e628-87347a03000f@linaro.org> (raw)
In-Reply-To: <b9b77873-9004-425c-276d-ea5ef8ebf7dc@9elements.com>
On 03/11/2022 14:20, Naresh Solanki wrote:
>
>
> On 03-11-2022 11:31 pm, Krzysztof Kozlowski wrote:
>> OK, so indeed there are improvements.
>>
>> Yet still you did not improve the warnings coming from the binding -
>> this does not match your binding. Test the binding and you will see big
>> fat warning.
> Not sure what I've missed but below is the output:
> make dt_binding_check -j1 V=1
> make -f ./scripts/Makefile.build obj=scripts/basic
> make -f ./scripts/Makefile.build obj=scripts/dtc
> make -f ./scripts/Makefile.build obj=Documentation/devicetree/bindings
> dt-extract-example
> Documentation/devicetree/bindings/mfd/maxim,max5970.yaml >
> Documentation/devicetree/bindings/mfd/maxim,max5970.example.dts
> gcc -E
> -Wp,-MMD,Documentation/devicetree/bindings/mfd/.maxim_max5970.example.dtb.d.pre.tmp
> -nostdinc -I./scripts/dtc/include-prefixes -undef -D__DTS__ -x
> assembler-with-cpp -o
> Documentation/devicetree/bindings/mfd/.maxim_max5970.example.dtb.dts.tmp
> Documentation/devicetree/bindings/mfd/maxim,max5970.example.dts ;
> ./scripts/dtc/dtc -o
> Documentation/devicetree/bindings/mfd/maxim,max5970.example.dtb -b 0
> -iDocumentation/devicetree/bindings/mfd/
> -i./scripts/dtc/include-prefixes -Wno-avoid_unnecessary_addr_size
> -Wno-graph_child_address -Wno-interrupt_provider
> -Wno-unique_unit_address -Wunique_unit_address_if_enabled -d
> Documentation/devicetree/bindings/mfd/.maxim_max5970.example.dtb.d.dtc.tmp
> Documentation/devicetree/bindings/mfd/.maxim_max5970.example.dtb.dts.tmp
> ; cat
> Documentation/devicetree/bindings/mfd/.maxim_max5970.example.dtb.d.pre.tmp
> Documentation/devicetree/bindings/mfd/.maxim_max5970.example.dtb.d.dtc.tmp
> > Documentation/devicetree/bindings/mfd/.maxim_max5970.example.dtb.d ;
> dt-validate -u ./Documentation/devicetree/bindings -p
> ./Documentation/devicetree/bindings/processed-schema.json
> Documentation/devicetree/bindings/mfd/maxim,max5970.example.dtb || true
>
> Didn't get any error or warning on example.
> Made sure python package dt-schema is updated as well.
Eh, true, but you have there "additionalProperties: true" which are not
allowed. This must be false and about leds I commented. False must be in
all other places as well.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-11-03 20:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-03 8:05 [PATCH v6 0/2] mfd: max597x: Add support for max597x Naresh Solanki
2022-11-03 8:05 ` [PATCH v6 1/2] dt-bindings: mfd: Add bindings for MAX5970 and MAX5978 Naresh Solanki
2022-11-03 12:35 ` Rob Herring
2022-11-03 13:13 ` Krzysztof Kozlowski
2022-11-03 17:53 ` Naresh Solanki
2022-11-03 18:01 ` Krzysztof Kozlowski
2022-11-03 18:20 ` Naresh Solanki
2022-11-03 20:26 ` Krzysztof Kozlowski [this message]
2022-11-03 21:33 ` Naresh Solanki
2022-11-03 8:05 ` [PATCH v6 2/2] mfd: max597x: Add support " Naresh Solanki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3164343-3b0d-6672-e628-87347a03000f@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=naresh.solanki@9elements.com \
--cc=patrick.rudolph@9elements.com \
--cc=robh+dt@kernel.org \
--cc=sylv@sylv.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox