From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0FB0435837C for ; Wed, 18 Mar 2026 11:24:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.8 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773833089; cv=none; b=FHS3kcO7HYIzTPYnT3vlde2GkzickWqY5gVlv1OxW3pVmzQwJT9G7dcbR8RR6f4KjYGdoZO/RS//EMd9BxdYnNhQ5s7DAc9oMapChMSnfQV5UdV9Ghz7ok1EbPeTtyzt3wuDIMjOXrgbp2WEAuHtWtvKDtHgbil7ZOw0QCKuy1k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773833089; c=relaxed/simple; bh=7iYZhmzUVmRe9FqDsbg26T7NvenTXk+071AGD/Mpbbw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=XUzuErGgeu/5HfjG46ogrA9dQx+V1a+ebLZk8UqMhfXBl7wdkfUSFtBxmM67zGW7/raUydMdqpDjcwdDGDvTE+i/EbnGGtFfyKC7e9aEkFFOTWGlvqIb94ediUlW7GAa4gebJ9a3pnH+vE2IHnST/F6nFVox7g5t79RT0Y9qjhw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=LD1owGyu; arc=none smtp.client-ip=192.198.163.8 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="LD1owGyu" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1773833086; x=1805369086; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version:content-transfer-encoding; bh=7iYZhmzUVmRe9FqDsbg26T7NvenTXk+071AGD/Mpbbw=; b=LD1owGyu1KVhHvqarUMDU7dx6z6weHVpcCrANxGhsMhQqDaLJ2GmAkoI x+D4YjVlNlWfL79OdFmhU8y95QBnowCkHs57MqgA1yrdPH+d1dCA+dR80 yrYTRulY8cJKc4AbQAPLf1CNqLA5p1Kny+kBXgh32YsRgiJiQvUZRBJJp SwyandFsDLRNgnoTuarnPA8BIm/DrFgrfdmFhjpnWrcTR8svndmPPWQHh FUN/MeTsgUrMbvcy935Z6NoW1jlgbkw3DWz7e22tcDO6TwmH4p6/zr0nf ahc09Mq4pUzr/iLrHhL98PW3etlBxvi9EQEiky4LqbyxX6ZgvuJqVfjPh g==; X-CSE-ConnectionGUID: MjJiH1W6TdSUjHt+i4QB1Q== X-CSE-MsgGUID: 57zJp8tRREGmISmRehNs4A== X-IronPort-AV: E=McAfee;i="6800,10657,11732"; a="92453174" X-IronPort-AV: E=Sophos;i="6.23,127,1770624000"; d="scan'208";a="92453174" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Mar 2026 04:24:45 -0700 X-CSE-ConnectionGUID: vgBnmoh8QReLJ0Jmngc/pQ== X-CSE-MsgGUID: 2ye0oTnlSeGlrwalpRHuFg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,127,1770624000"; d="scan'208";a="222654923" Received: from slindbla-desk.ger.corp.intel.com (HELO localhost) ([10.245.246.79]) by orviesa008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Mar 2026 04:24:39 -0700 From: Jani Nikula To: Thomas Zimmermann , Arnd Bergmann , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Uma Shankar , Mika Kahola , Ville =?utf-8?B?U3lyasOkbMOk?= , Vinod Govindapillai Cc: Arnd Bergmann , Jouni =?utf-8?Q?H=C3=B6gander?= , Chaitanya Kumar Borah , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/i915/fbdev: fix link failure without FBDEV emulation In-Reply-To: <9b3354fe-ff49-4436-9f36-2a19eaf2918c@suse.de> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs Bertel Jungin Aukio 5, 02600 Espoo, Finland References: <20260304083701.724908-1-arnd@kernel.org> <9b3354fe-ff49-4436-9f36-2a19eaf2918c@suse.de> Date: Wed, 18 Mar 2026 13:24:36 +0200 Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Mon, 16 Mar 2026, Thomas Zimmermann wrote: > Hi > > Am 04.03.26 um 09:43 schrieb Thomas Zimmermann: >> Hi >> >> Am 04.03.26 um 09:36 schrieb Arnd Bergmann: >>> From: Arnd Bergmann >>> >>> If CONFIG_DRM_FBDEV_EMULATION is disabled but CONFIG_FRAMEBUFFER_CONSOLE >>> is turned on, the i915 driver now fails to link: >>> >>> ERROR: modpost: "intel_fbdev_fb_prefer_stolen"=20 >>> [drivers/gpu/drm/i915/i915.ko] undefined! >>> >>> Fix the contition to include a check for the symbol that controls=20 >>> compilation >>> of intel_fbdev_fb.c. >>> >>> Fixes: 94c7d2861292 ("drm/i915/fbdev: Extract=20 >>> intel_fbdev_fb_prefer_stolen()") >>> Signed-off-by: Arnd Bergmann >>> --- >>> =C2=A0 drivers/gpu/drm/i915/i915_initial_plane.c | 3 ++- >>> =C2=A0 1 file changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/drivers/gpu/drm/i915/i915_initial_plane.c=20 >>> b/drivers/gpu/drm/i915/i915_initial_plane.c >>> index 5594548f51d8..390a9248d631 100644 >>> --- a/drivers/gpu/drm/i915/i915_initial_plane.c >>> +++ b/drivers/gpu/drm/i915/i915_initial_plane.c >>> @@ -115,7 +115,8 @@ initial_plane_vma(struct drm_i915_private *i915, >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * important and we should probably= use that space with FBC or=20 >>> other >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * features. >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 */ >>> -=C2=A0=C2=A0=C2=A0 if (IS_ENABLED(CONFIG_FRAMEBUFFER_CONSOLE) && >>> +=C2=A0=C2=A0=C2=A0 if (IS_ENABLED(CONFIG_DRM_FBDEV_EMULATION) && >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 IS_ENABLED(CONFIG_FRAMEBUFF= ER_CONSOLE) && >> >> It's possible to run fbdev without the console. So if I'm not=20 >> mistaken, only CONFIG_DRM_FBDEV_EMULATION would be correct. > > Did anyone pick up this fix? Pushed to drm-intel-next, thanks for the patch. BR, Jani. > > Best regards > Thomas > >> >> Best regards >> Thomas >> >> >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 mem =3D=3D i915-= >mm.stolen_region && >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 !intel_fbdev_fb_= prefer_stolen(&i915->drm, size)) { >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 drm_dbg_kms(&i91= 5->drm, "Initial FB size exceeds half of=20 >>> stolen, discarding\n"); >> --=20 Jani Nikula, Intel