From: Brijesh Singh <brijesh.singh@amd.com>
To: Borislav Petkov <bp@alien8.de>
Cc: brijesh.singh@amd.com, linux-crypto@vger.kernel.org,
thomas.lendacky@amd.com, Gary Hook <Gary.Hook@amd.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH crypto-2.6] crypto: ccp: add timeout support in the SEV command
Date: Mon, 10 Sep 2018 14:06:57 -0500 [thread overview]
Message-ID: <e327fa7f-2d4d-2181-c3f4-607faf16c9b5@amd.com> (raw)
In-Reply-To: <20180904081151.GC32615@zn.tnic>
Hi Boris,
On 09/04/2018 03:11 AM, Borislav Petkov wrote:
...
>> +
>> +static int psp_probe_timeout = 5;
>> +module_param(psp_probe_timeout, int, 0644);
>> +MODULE_PARM_DESC(psp_probe_timeout, " default timeout value, in seconds, during PSP device probe");
>
> Just a question: what prevents the user from supplying non-sensical
> values here?
>
> I think we should clamp them to only allowed values because I don't want
> to be debugging some strange bugs due to that.
>
Nothing prevent user from supplying a bogus number. The main question
is, clamp with what number ?
IMO, if user is overriding the default timeout number then its possible
that user is dealing with a buggy firmware which does not work with
default timeout and silently clamping the value will not help them.
- Brijesh
next prev parent reply other threads:[~2018-09-10 19:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1534367485-4386-1-git-send-email-brijesh.singh@amd.com>
2018-08-15 21:11 ` [PATCH crypto-2.6] crypto: ccp: add timeout support in the SEV command Brijesh Singh
2018-09-04 5:19 ` Herbert Xu
2018-09-12 0:11 ` Brijesh Singh
2018-09-13 5:02 ` Herbert Xu
2018-09-04 8:11 ` Borislav Petkov
2018-09-10 19:06 ` Brijesh Singh [this message]
2018-09-11 13:53 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e327fa7f-2d4d-2181-c3f4-607faf16c9b5@amd.com \
--to=brijesh.singh@amd.com \
--cc=Gary.Hook@amd.com \
--cc=bp@alien8.de \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox