From: SF Markus Elfring <elfring@users.sourceforge.net>
To: linux-cris-kernel@axis.com,
Alexander Sverdlin <alexander.sverdlin@gmail.com>,
Boris Brezillon <boris.brezillon@free-electrons.com>,
Gregory Clement <gregory.clement@free-electrons.com>,
Jesper Nilsson <jesper.nilsson@axis.com>,
Krzysztof Halasa <khalasa@piap.pl>,
Mikael Starvik <starvik@axis.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Shawn Guo <shawnguo@kernel.org>, Tony Lindgren <tony@atomide.com>,
Vladimir Zapolskiy <vz@mleia.com>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: [PATCH 4/5] cris: nand: Delete an unnecessary local variable in crisv32_nand_flash_probe()
Date: Wed, 4 Oct 2017 20:48:52 +0200 [thread overview]
Message-ID: <e3759e95-cd25-0272-aea4-8b0f347dbf80@users.sourceforge.net> (raw)
In-Reply-To: <cd84411c-d202-70d6-dec2-c02bedaf3594@users.sourceforge.net>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 4 Oct 2017 19:32:18 +0200
The local variable "err" was never read in this function.
Thus remove it.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
arch/cris/arch-v32/drivers/mach-a3/nandflash.c | 6 +-----
arch/cris/arch-v32/drivers/mach-fs/nandflash.c | 10 ++--------
2 files changed, 3 insertions(+), 13 deletions(-)
diff --git a/arch/cris/arch-v32/drivers/mach-a3/nandflash.c b/arch/cris/arch-v32/drivers/mach-a3/nandflash.c
index f30579ec8ad7..03a01bfa6ad9 100644
--- a/arch/cris/arch-v32/drivers/mach-a3/nandflash.c
+++ b/arch/cris/arch-v32/drivers/mach-a3/nandflash.c
@@ -108,7 +108,6 @@ struct mtd_info *__init crisv32_nand_flash_probe(void)
struct mtd_info_wrapper *wrapper;
struct nand_chip *this;
- int err = 0;
reg_pio_rw_man_ctrl man_ctrl = {
.regf_NCE = regk_pio_yes,
@@ -135,10 +134,8 @@ struct mtd_info *__init crisv32_nand_flash_probe(void)
/* Allocate memory for MTD device structure and private data */
wrapper = kzalloc(sizeof(*wrapper), GFP_KERNEL);
- if (!wrapper) {
- err = -ENOMEM;
+ if (!wrapper)
return NULL;
- }
read_cs = write_cs = (void __iomem *)REG_ADDR(pio, regi_pio,
rw_io_access0);
@@ -162,7 +159,6 @@ struct mtd_info *__init crisv32_nand_flash_probe(void)
/* Scan to find existence of the device */
if (nand_scan(crisv32_mtd, 1)) {
- err = -ENXIO;
kfree(wrapper);
return NULL;
}
diff --git a/arch/cris/arch-v32/drivers/mach-fs/nandflash.c b/arch/cris/arch-v32/drivers/mach-fs/nandflash.c
index 5dfd72a89b8a..2b53f0c615ea 100644
--- a/arch/cris/arch-v32/drivers/mach-fs/nandflash.c
+++ b/arch/cris/arch-v32/drivers/mach-fs/nandflash.c
@@ -106,21 +106,17 @@ struct mtd_info *__init crisv32_nand_flash_probe(void)
reg_gio_rw_pa_oe pa_oe = REG_RD(gio, regi_gio, rw_pa_oe);
struct mtd_info_wrapper *wrapper;
struct nand_chip *this;
- int err = 0;
/* Allocate memory for MTD device structure and private data */
wrapper = kzalloc(sizeof(*wrapper), GFP_KERNEL);
- if (!wrapper) {
- err = -ENOMEM;
+ if (!wrapper)
return NULL;
- }
read_cs = ioremap(MEM_CSP0_START | MEM_NON_CACHEABLE, 8192);
write_cs = ioremap(MEM_CSP1_START | MEM_NON_CACHEABLE, 8192);
if (!read_cs || !write_cs) {
printk(KERN_ERR "CRISv32 NAND ioremap failed\n");
- err = -EIO;
goto out_mtd;
}
@@ -152,10 +148,8 @@ struct mtd_info *__init crisv32_nand_flash_probe(void)
/* this->bbt_options = NAND_BBT_USE_FLASH; */
/* Scan to find existence of the device */
- if (nand_scan(crisv32_mtd, 1)) {
- err = -ENXIO;
+ if (nand_scan(crisv32_mtd, 1))
goto out_ior;
- }
return crisv32_mtd;
--
2.14.2
next prev parent reply other threads:[~2017-10-04 18:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-04 18:43 [PATCH 0/5] CRIS v32: Adjustments for crisv32_nand_flash_probe() SF Markus Elfring
2017-10-04 18:45 ` [PATCH 1/5] cris: nand: Delete an error message for a failed memory allocation in crisv32_nand_flash_probe() SF Markus Elfring
2017-10-04 19:44 ` Alexander Sverdlin
2017-10-04 19:55 ` SF Markus Elfring
2017-10-04 20:12 ` [PATCH 1/5] " Julia Lawall
2017-10-04 20:16 ` Alexander Sverdlin
2017-10-04 18:46 ` [PATCH 2/5] cris: nand: Improve a size determination " SF Markus Elfring
2017-10-04 18:47 ` [PATCH 3/5] cris: nand: Delete a jump target " SF Markus Elfring
2017-10-04 18:48 ` SF Markus Elfring [this message]
2017-10-04 20:17 ` [PATCH 4/5] cris: nand: Delete an unnecessary local variable " Alexander Sverdlin
2017-10-04 18:50 ` [PATCH 5/5] cris: nand: Split a condition check " SF Markus Elfring
2017-10-04 20:26 ` Alexander Sverdlin
2017-10-05 15:31 ` [PATCH 0/5] CRIS v32: Adjustments for crisv32_nand_flash_probe() Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3759e95-cd25-0272-aea4-8b0f347dbf80@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=alexander.sverdlin@gmail.com \
--cc=boris.brezillon@free-electrons.com \
--cc=gregory.clement@free-electrons.com \
--cc=jesper.nilsson@axis.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=khalasa@piap.pl \
--cc=linux-cris-kernel@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=shawnguo@kernel.org \
--cc=starvik@axis.com \
--cc=tony@atomide.com \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox