From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0047032E13A for ; Tue, 6 Jan 2026 13:00:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767704416; cv=none; b=AhwTMEUcNCG1D5MkPI2VN6xzhQt/YrHLHwUKtcKHerWV5KXvVmnGSvYoIM0Hxe9fnni3plaWFLza5GZ0S6Hy6sqgJUftG5/C9Tcxzby7h86MQVnwRQr8Xo0Wblrh3/3jHFhD8hRmvobSfBNkMfBzZE4fngRJZoBsh/JWyHGmW28= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767704416; c=relaxed/simple; bh=0om2bX45QNGjgdqYVBRYqDITF50Dzz/TKfhxXmJQ3ok=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qlrHHg+NFdA16RIWKDY0xWedLAhW61Yhs9Z/fSwvGKlxTM9zSHInVLcaqtf7ZNrNAxH++qNouOQGLAGtYJi99gDGEA+OrHNPL+ArABNw3AXSSK3b8+ZT4F+9lk43BxTE5ry8jOc4NrRpjwWveKZhvZlsPu0HnJGdSATYJwWsgTk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=TRS+iD20; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=TC7e8zeY; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="TRS+iD20"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="TC7e8zeY" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 606BJfFG2253762 for ; Tue, 6 Jan 2026 13:00:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= huXgOWlwMM/3UBQ256PZnVk2f03NpWBmmvrJXgXD0Ak=; b=TRS+iD206qbp/Mkt 9OdYG4UisDFYd5ntCFRwFJ4HZaVAhjc73UvHfPF2sV+0KWWDWhvhgyWgDcwdyrFi npyzzP2A3ZGUZCfZ7K73l9nknH5H270HR0PikxT3sSj89UrAvmch17byE5+eJrWo K6dU/LjC/EhbcKwUXp+Vpr6Z+JuEqJ5aSm1NPdKL5zRJatwEuFbF1324Dxvi8gBK RQEoWDurhc0bIm7C1OWOg2KSqyOyHSPF/BfrqeiRpS2Z/9vTBcQktf6a2m+kSeTs KFjsgT8XqSNzHrMx3zERwRSrsV8iU/X0YHJzuvfFjOQAPZvmo+Kh/zDGTM10ymWg ZxVtVg== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bgu421dxj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 06 Jan 2026 13:00:13 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-29f1f69eec6so12112195ad.1 for ; Tue, 06 Jan 2026 05:00:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767704413; x=1768309213; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=huXgOWlwMM/3UBQ256PZnVk2f03NpWBmmvrJXgXD0Ak=; b=TC7e8zeYy3qyt65qqxjyjkHOvdeaKW26EkBtSwY58FpIgEakqKUwtY1LasAXuEmYcO 2Ll3mTUaMBoPeimpAIdbzZ6iuDt9FWfMVEfMRxB1Nd3a96v7OAGJFke9tPtCjwo3Axcj QVblBcAA3HRyOQXWTNzvjFJQPF0aFYUkJkzC73eqzvLMTaEGv9rydPWFq8HW7+tNYVV+ Sp6QcRV1syfoXzNfYfhUaAoKv/JK0zUqOfiJ9N7O+nL2RvYlabnORAYbjduBrurCkZ2n LciuWPzzO7OJA64/KzEEPjdCpOGLkFsNXnibzh/l7TTILg8mhe5KPXTiIdFz/ycwI7AX wugA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767704413; x=1768309213; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=huXgOWlwMM/3UBQ256PZnVk2f03NpWBmmvrJXgXD0Ak=; b=IqPzccF41WPuisHUpE4lDBXxsjIqwuCE02Cv/vx61Hzpl/THbo+Y3JeZzcIHzaPI6i K28rneKodBOfduey1goB4bbVV7nB29T9TCLVMZmr9qyv6g4wTZWCOBWxjTZH/wQtaiS5 HopElKBSgdgQG/O5xempWC6IZr1pGH3vrTM69Y5sdIx2jOqzwS8wXdVw0hl6SfXfC1ko bveiT81io/0QeLlzQoM3lFWPXBgviD6P3aRIiENvs7c3EPcKhZxF0Z7uDDCvU/jbGmCR IC1XmVH8ES4tWOc9DBRDeonFXSYb7pPlKzoPDLh6Is53QxPCLxHlds4FueNTdmwSpTZR 2AUQ== X-Forwarded-Encrypted: i=1; AJvYcCU2DUkbngrGAx22I8SPCuDZBvnP0jFSkAnsfQT6eVY25jjQUWZJ14Lg+083ce4pepfj9bd1tkgwdeI6vMg=@vger.kernel.org X-Gm-Message-State: AOJu0Yx/yGxBAOftx+NlDhJ3Yv5+Btksni1JHQ7l2uSvDXt2+138SqWD 7+ZwzkhEH9sLd4NiXnpOPrGI3xoTOlybtdGcuUdkn7lCB7VI8git1gSR5Gn+wq3KYkwX9bNB567 EXiCH7xYj/82jCTAsGX3kKYzfK8BQulEBaXb+pSn9oGDOZ4UiWHKvySdyznp6cYe8jV5XAoSp/c 4= X-Gm-Gg: AY/fxX7+J8+69JiTIhFOkNw2fS5xk3yMam65vFWa1kAMqnFjt43cpmEBT+2MhjO1M4X fYFhW6FgDodDorxQ8s4nd/bWVA3TZ8XYvfI486eRL5hQDlxh16vpU/7PDK/x7atb4RmkaFRFxKY 4YrbqFwT13Sbhu1zX3hMaaAr4qfwyrXWi7v09rEM5wRkqDgXJlvxpBI2HgzRu0d/xVlb28rMVmY kgNc/pWkR1wZK7opoE81ROnEQMzqrGT5OH2gKNrxwVu13llpNS9+OWIQCNh1dTiSfwh7zVdSQEr 7NwnqdDz3d69TXycRr40lDG6CS1s+CL7gN9cDlPo7Ef+r1RJgAJ1y1G+2OqXiKjAFrSvYLoFfvF GFsCZE3TYYRz9b/09AazRFkYs7yAkgU4XuvxwHmwiylPAMcFpHR4= X-Received: by 2002:a17:903:1a08:b0:2a0:8f6f:1a0d with SMTP id d9443c01a7336-2a3e2d4a754mr28039965ad.61.1767704411955; Tue, 06 Jan 2026 05:00:11 -0800 (PST) X-Google-Smtp-Source: AGHT+IEj1eTxDDzV+0Q9BC5FCCAwWShTr88gsLB31ddtNM4i8U1yoesSaOsi/0lEA1kMP18LZTgfqA== X-Received: by 2002:a17:903:1a08:b0:2a0:8f6f:1a0d with SMTP id d9443c01a7336-2a3e2d4a754mr28039695ad.61.1767704411315; Tue, 06 Jan 2026 05:00:11 -0800 (PST) Received: from [10.217.216.105] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a3e3cc8803sm22780885ad.71.2026.01.06.05.00.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Jan 2026 05:00:10 -0800 (PST) Message-ID: Date: Tue, 6 Jan 2026 18:30:05 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V3 3/4] arm64: dts: qcom: hamoa: Add UFS nodes for x1e80100 SoC To: Manivannan Sadhasivam Cc: vkoul@kernel.org, neil.armstrong@linaro.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, martin.petersen@oracle.com, andersson@kernel.org, konradybcio@kernel.org, taniya.das@oss.qualcomm.com, dmitry.baryshkov@oss.qualcomm.com, linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, nitin.rawat@oss.qualcomm.com, Konrad Dybcio , Abel Vesa References: <20260105144643.669344-1-pradeep.pragallapati@oss.qualcomm.com> <20260105144643.669344-4-pradeep.pragallapati@oss.qualcomm.com> <7gi7sh5psh5v4y5mrbgln6j2cjeu5mogdw2n3a6znjtqyjcyuk@kxpe566v57p3> Content-Language: en-US From: Pradeep Pragallapati In-Reply-To: <7gi7sh5psh5v4y5mrbgln6j2cjeu5mogdw2n3a6znjtqyjcyuk@kxpe566v57p3> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=dYuNHHXe c=1 sm=1 tr=0 ts=695d075d cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=CRlJY8YO9k0lXNWMlzEA:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-GUID: 6JmRycf8CErWCeVJ3y82ukW7feCZATO5 X-Proofpoint-ORIG-GUID: 6JmRycf8CErWCeVJ3y82ukW7feCZATO5 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTA2MDExMiBTYWx0ZWRfX19CYCQj2oI8p 3hNoV3VSwMBWyFA+NcgTtQ/wVmWaJkcPgPT982s9o7aXQpTT23KVByjY2FevppdVkMCWMO0ZC+Q BLm89AOL0O3eTsL0RDMCwfbs9ru6KRHPqZI6OLPwhx8EyU92nVz2Ki2Zz5XdYChl5UNELF4viLy sFUta9NUduRO6OgNVA9U7P7Pth6DMeZRkDEQP/z2B9Kk9KuwqssFxL6ZfH7ZvFENvC72bQE6qhM 97t8KGjZJNXmcq3/9cRVkoLfaRPyAKrpC7wEz1yNb0Elwn/CkEDINv2xhVvjdKVBT7ZVr7olh11 gu3iA/adhziT9pQIFNkBmDgqeVKRq0hEPsJ+fMwX00p9nQ6fCyxEr/pdwaqA1ee4evB+2Yz4NEX uH0i3w0sKCAGtJ/Wx+bu8fPjHBFRlHuWU6Dw3tDCU27upG2j+9EcjflJXd7Mv8CnvFbBMK2a7zS hFb63nLKDBVJo8m46iQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-06_01,2026-01-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 adultscore=0 malwarescore=0 impostorscore=0 phishscore=0 clxscore=1015 spamscore=0 lowpriorityscore=0 suspectscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601060112 On 1/6/2026 1:36 PM, Manivannan Sadhasivam wrote: > On Mon, Jan 05, 2026 at 08:16:42PM +0530, Pradeep P V K wrote: >> Add UFS host controller and PHY nodes for x1e80100 SoC. >> > > Minor nits below. With those fixed, > > Reviewed-by: Manivannan Sadhasivam > >> Reviewed-by: Konrad Dybcio >> Reviewed-by: Abel Vesa >> Reviewed-by: Taniya Das >> Signed-off-by: Pradeep P V K >> --- >> arch/arm64/boot/dts/qcom/hamoa.dtsi | 123 +++++++++++++++++++++++++++- >> 1 file changed, 120 insertions(+), 3 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/qcom/hamoa.dtsi b/arch/arm64/boot/dts/qcom/hamoa.dtsi >> index f7d71793bc77..33899fa06aa4 100644 >> --- a/arch/arm64/boot/dts/qcom/hamoa.dtsi >> +++ b/arch/arm64/boot/dts/qcom/hamoa.dtsi >> @@ -835,9 +835,9 @@ gcc: clock-controller@100000 { >> <0>, >> <0>, >> <0>, >> - <0>, >> - <0>, >> - <0>; >> + <&ufs_mem_phy 0>, >> + <&ufs_mem_phy 1>, >> + <&ufs_mem_phy 2>; >> >> power-domains = <&rpmhpd RPMHPD_CX>; >> #clock-cells = <1>; >> @@ -3848,6 +3848,123 @@ pcie4_phy: phy@1c0e000 { >> status = "disabled"; >> }; >> >> + ufs_mem_phy: phy@1d80000 { >> + compatible = "qcom,x1e80100-qmp-ufs-phy", >> + "qcom,sm8550-qmp-ufs-phy"; >> + reg = <0x0 0x01d80000 0x0 0x2000>; >> + >> + clocks = <&rpmhcc RPMH_CXO_CLK>, >> + <&gcc GCC_UFS_PHY_PHY_AUX_CLK>, >> + <&tcsr TCSR_UFS_PHY_CLKREF_EN>; >> + >> + clock-names = "ref", >> + "ref_aux", >> + "qref"; >> + resets = <&ufs_mem_hc 0>; >> + reset-names = "ufsphy"; >> + >> + power-domains = <&gcc GCC_UFS_MEM_PHY_GDSC>; >> + >> + #clock-cells = <1>; >> + #phy-cells = <0>; >> + >> + status = "disabled"; >> + }; >> + >> + ufs_mem_hc: ufs@1d84000 { > > ufshc@ ok, i will update in the next patchset. > >> + compatible = "qcom,x1e80100-ufshc", >> + "qcom,sm8550-ufshc", >> + "qcom,ufshc", >> + "jedec,ufs-2.0"; > > Drop jedec compatible as Qcom UFS controller cannot fallback to generic ufshc > driver. "jedec,ufs-2.0" was set to const in dt-bindings, dropping now will lead to dtbs_check failures. is it ok, if i continue with it ? > > - Mani >