From: Krzysztof Kozlowski <krzk@kernel.org>
To: Esben Haabendal <esben@geanix.com>
Cc: Tudor Ambarus <tudor.ambarus@linaro.org>,
Pratyush Yadav <pratyush@kernel.org>,
Michael Walle <mwalle@kernel.org>,
linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org
Subject: Re: [PATCH] memory: fsl_ifc: Make FSL_IFC config visible and selectable
Date: Tue, 28 May 2024 08:53:26 +0200 [thread overview]
Message-ID: <e3aa72af-c824-4b71-a99d-c0b9294bfd8a@kernel.org> (raw)
In-Reply-To: <87ikyzae7v.fsf@geanix.com>
On 27/05/2024 09:47, Esben Haabendal wrote:
>
> Ok, I seem to still be confused as to what you want from me. If you are
> saying that the kernel is not supposed to care about out-of-tree DTS
> (and thereby any bootloader provided DTB), I would like to bring your
> attention to arch/arm/boot/dts/nxp/ls/ls1021a-twr.dts in upstream:
>
> &ifc {
> #address-cells = <2>;
> #size-cells = <1>;
> /* NOR Flash on board */
> ranges = <0x0 0x0 0x0 0x60000000 0x08000000>;
> status = "okay";
>
> nor@0,0 {
> #address-cells = <1>;
> #size-cells = <1>;
> compatible = "cfi-flash";
> reg = <0x0 0x0 0x8000000>;
> big-endian;
> bank-width = <2>;
> device-width = <1>;
> };
> };
>
I don't understand why it took so many emails to answer that (my first)
question... Sounds good, however you did not update the existing select.
Drivers are not supposed to select user-visible symbols (leads to
issues), so you need to change it to depends and update defconfigs.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-05-28 6:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-23 13:58 [PATCH] memory: fsl_ifc: Make FSL_IFC config visible and selectable Esben Haabendal
2024-05-23 14:01 ` Krzysztof Kozlowski
2024-05-23 14:32 ` Esben Haabendal
2024-05-23 14:36 ` Krzysztof Kozlowski
2024-05-24 8:47 ` Esben Haabendal
2024-05-25 16:41 ` Krzysztof Kozlowski
2024-05-27 6:55 ` Esben Haabendal
2024-05-27 7:19 ` Krzysztof Kozlowski
2024-05-27 7:35 ` Esben Haabendal
2024-05-27 7:47 ` Esben Haabendal
2024-05-28 6:53 ` Krzysztof Kozlowski [this message]
2024-05-28 10:03 ` Esben Haabendal
2024-05-28 10:21 ` Krzysztof Kozlowski
2024-05-28 11:01 ` Esben Haabendal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3aa72af-c824-4b71-a99d-c0b9294bfd8a@kernel.org \
--to=krzk@kernel.org \
--cc=esben@geanix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=mwalle@kernel.org \
--cc=pratyush@kernel.org \
--cc=tudor.ambarus@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox