From: SF Markus Elfring <elfring@users.sourceforge.net>
To: linux-s390@vger.kernel.org,
"Christian Bornträger" <borntraeger@de.ibm.com>,
"Heiko Carstens" <heiko.carstens@de.ibm.com>,
"Ingo Molnar" <mingo@kernel.org>,
"Martin Schwidefsky" <schwidefsky@de.ibm.com>,
"Paul Gortmaker" <paul.gortmaker@windriver.com>,
"Peter Oberparleiter" <oberpar@linux.vnet.ibm.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Sascha Silbe" <silbe@linux.vnet.ibm.com>,
"Vegard Nossum" <vegard.nossum@oracle.com>,
"Viktor Mihajlovski" <mihajlov@linux.vnet.ibm.com>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: [PATCH 1/4] s390/cache: Combine two function calls into one in show_cacheinfo()
Date: Sun, 7 May 2017 19:13:59 +0200 [thread overview]
Message-ID: <e3d24bcc-782b-5c05-1d46-cdcbbbe3bbdf@users.sourceforge.net> (raw)
In-Reply-To: <fac68081-f0bb-2574-ba52-11ad78d792c3@users.sourceforge.net>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 7 May 2017 17:53:31 +0200
A bit of data was put into a sequence by two separate function calls.
Print the same data by a single function call instead.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
arch/s390/kernel/cache.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/s390/kernel/cache.c b/arch/s390/kernel/cache.c
index c8a83276a4dc..9e9752ce3233 100644
--- a/arch/s390/kernel/cache.c
+++ b/arch/s390/kernel/cache.c
@@ -82,8 +82,8 @@ void show_cacheinfo(struct seq_file *m)
cache->disable_sysfs ? "Shared" : "Private");
seq_printf(m, "size=%dK ", cache->size >> 10);
seq_printf(m, "line_size=%u ", cache->coherency_line_size);
- seq_printf(m, "associativity=%d", cache->ways_of_associativity);
- seq_puts(m, "\n");
+ seq_printf(m, "associativity=%d\n",
+ cache->ways_of_associativity);
}
}
--
2.12.2
next prev parent reply other threads:[~2017-05-07 21:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-07 17:12 [PATCH 0/4] S390: Fine-tuning for six function implementations SF Markus Elfring
2017-05-07 17:13 ` SF Markus Elfring [this message]
2017-05-07 17:14 ` [PATCH 2/4] s390/processor: Use seq_putc() in show_cpu_summary() SF Markus Elfring
2017-05-07 17:16 ` [PATCH 3/4] s390/sysinfo: Replace six seq_printf() calls by seq_puts() SF Markus Elfring
2017-05-07 17:18 ` [PATCH 4/4] s390/sysinfo: Combine two function calls into one SF Markus Elfring
2017-05-09 8:04 ` [PATCH 0/4] S390: Fine-tuning for six function implementations Vegard Nossum
2017-05-09 8:43 ` SF Markus Elfring
2017-05-09 10:30 ` [PATCH 0/4] " Ingo Molnar
2017-05-09 10:54 ` SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3d24bcc-782b-5c05-1d46-cdcbbbe3bbdf@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=borntraeger@de.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mihajlov@linux.vnet.ibm.com \
--cc=mingo@kernel.org \
--cc=oberpar@linux.vnet.ibm.com \
--cc=paul.gortmaker@windriver.com \
--cc=peterz@infradead.org \
--cc=schwidefsky@de.ibm.com \
--cc=silbe@linux.vnet.ibm.com \
--cc=vegard.nossum@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox