From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751985AbeEPV1G (ORCPT ); Wed, 16 May 2018 17:27:06 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:37176 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751132AbeEPV1F (ORCPT ); Wed, 16 May 2018 17:27:05 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 16 May 2018 14:27:04 -0700 From: Subhash Jadavani To: Alim Akhtar Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, jejb@linux.vnet.ibm.com, martin.petersen@oracle.com, vivek.gautam@codeaurora.org, vinholikatti@gmail.com, olof@lixom.net Subject: Re: [PATCH 4/4] scsi: ufs: make ufshcd_config_pwr_mode of non-static func In-Reply-To: <1525601658-31989-5-git-send-email-alim.akhtar@samsung.com> References: <1525601658-31989-1-git-send-email-alim.akhtar@samsung.com> <1525601658-31989-5-git-send-email-alim.akhtar@samsung.com> Message-ID: User-Agent: Roundcube Webmail/1.2.5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018-05-06 03:14, Alim Akhtar wrote: > This makes ufshcd_config_pwr_mode non-static so that other vendors > like exynos can use the same. > > Signed-off-by: Seungwon Jeon > Signed-off-by: Alim Akhtar > --- > drivers/scsi/ufs/ufshcd.c | 5 ++--- > drivers/scsi/ufs/ufshcd.h | 2 ++ > 2 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c > index 5bfd385..68aefcd 100644 > --- a/drivers/scsi/ufs/ufshcd.c > +++ b/drivers/scsi/ufs/ufshcd.c > @@ -233,8 +233,6 @@ static void ufshcd_suspend_clkscaling(struct > ufs_hba *hba); > static void __ufshcd_suspend_clkscaling(struct ufs_hba *hba); > static int ufshcd_scale_clks(struct ufs_hba *hba, bool scale_up); > static irqreturn_t ufshcd_intr(int irq, void *__hba); > -static int ufshcd_config_pwr_mode(struct ufs_hba *hba, > - struct ufs_pa_layer_attr *desired_pwr_mode); > static int ufshcd_change_power_mode(struct ufs_hba *hba, > struct ufs_pa_layer_attr *pwr_mode); > static inline bool ufshcd_valid_tag(struct ufs_hba *hba, int tag) > @@ -3969,7 +3967,7 @@ static int ufshcd_change_power_mode(struct > ufs_hba *hba, > * @hba: per-adapter instance > * @desired_pwr_mode: desired power configuration > */ > -static int ufshcd_config_pwr_mode(struct ufs_hba *hba, > +int ufshcd_config_pwr_mode(struct ufs_hba *hba, > struct ufs_pa_layer_attr *desired_pwr_mode) > { > struct ufs_pa_layer_attr final_params = { 0 }; > @@ -3987,6 +3985,7 @@ static int ufshcd_config_pwr_mode(struct ufs_hba > *hba, > > return ret; > } > +EXPORT_SYMBOL_GPL(ufshcd_config_pwr_mode); > > /** > * ufshcd_complete_dev_init() - checks device readiness > diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h > index 013a07e..b42a5a3 100644 > --- a/drivers/scsi/ufs/ufshcd.h > +++ b/drivers/scsi/ufs/ufshcd.h > @@ -805,6 +805,8 @@ extern int ufshcd_dme_set_attr(struct ufs_hba > *hba, u32 attr_sel, > u8 attr_set, u32 mib_val, u8 peer); > extern int ufshcd_dme_get_attr(struct ufs_hba *hba, u32 attr_sel, > u32 *mib_val, u8 peer); > +extern int ufshcd_config_pwr_mode(struct ufs_hba *hba, > + struct ufs_pa_layer_attr *desired_pwr_mode); > > /* UIC command interfaces for DME primitives */ > #define DME_LOCAL 0 Looks good to me. Reviewed-by: Subhash Jadavani -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project