Re: [PATCH v3 04/26] fs/resctrl: Set up Kconfig options for telemetry events

Reinette Chatre
2025-04-18T21:23:14Z

Hi Tony,

On 4/7/25 4:40 PM, Tony Luck wrote:
> Enumeration support is provided by the Intel PMT subsystem.

Needs context before jumping in with solution.

>
> arch/x86 selects this option based on:
>
> X86_64: Counter registers are in MMIO space. There is no readq()
> function on 32-bit. Emulation is possible with readl(), but there
> are races. Running 32-bit kernels on systems that support this
> feature seems pointless.
>
> CPU_SUP_INTEL: It is an Intel specific feature.
>
> Signed-off-by: Tony Luck <tony.luck@intel.com>
> ---
> arch/x86/Kconfig | 1 +
> drivers/platform/x86/intel/pmt/Kconfig | 6 ++++++
> 2 files changed, 7 insertions(+)
>
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index ea29d22a621f..44a195ee7a42 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -504,6 +504,7 @@ config X86_CPU_RESCTRL
> bool "x86 CPU resource control support"
> depends on X86 && (CPU_SUP_INTEL || CPU_SUP_AMD)
> depends on MISC_FILESYSTEMS
> + select INTEL_AET_RESCTRL if (X86_64 && CPU_SUP_INTEL)
> select ARCH_HAS_CPU_RESCTRL
> select RESCTRL_FS
> select RESCTRL_FS_PSEUDO_LOCK
> diff --git a/drivers/platform/x86/intel/pmt/Kconfig b/drivers/platform/x86/intel/pmt/Kconfig
> index e916fc966221..b282910b49ef 100644
> --- a/drivers/platform/x86/intel/pmt/Kconfig
> +++ b/drivers/platform/x86/intel/pmt/Kconfig
> @@ -38,3 +38,9 @@ config INTEL_PMT_CRASHLOG
>
> To compile this driver as a module, choose M here: the module
> will be called intel_pmt_crashlog.
> +
> +config INTEL_AET_RESCTRL
> + bool

Usually these settings come with some "depends on" ... no dependencies needed?

> + help
> + Architecture config should "select" this option to enable
> + support for RMID telemtry events in the resctrl file system.

telemtry -> telemetry

Please define what is meant with "RMID telemetry events" before this statement.

Reinette