From: Stefan Schweizer <genstef@gentoo.org>
To: linux-kernel@vger.kernel.org
Cc: i4ldeveloper@listserv.isdn4linux.de
Subject: Re: [PATCH 2.6.17-rc3] Fix capi reload by unregistering the correct major
Date: Tue, 09 May 2006 19:12:14 +0200 [thread overview]
Message-ID: <e3qihe$3q2$1@sea.gmane.org> (raw)
In-Reply-To: 20060508130029.08a9a962.akpm@osdl.org
Andrew Morton wrote:
> Stefan Schweizer <genstef@gentoo.org> wrote:
>> --- drivers/isdn/capi/capi.c.orig 2006-04-29 18:40:25.000000000 +0200
>> +++ drivers/isdn/capi/capi.c 2006-04-29 18:27:22.000000000 +0200
>> @@ -1499,7 +1499,6 @@
>> printk(KERN_ERR "capi20: unable to get major %d\n", capi_major);
>> return major_ret;
>> }
>> - capi_major = major_ret;
>> capi_class = class_create(THIS_MODULE, "capi");
>> if (IS_ERR(capi_class)) {
>> unregister_chrdev(capi_major, "capi20");
>>
>>
>>
>
> What does "unload and retry" mean?
>
> An `rmmod capi;modprobe capi' will reset the major to 68, so you must mean
> something else. What?
I mean exactly rmmod capi; modprobe capi. The problem is, that on unload
time, the capi_major has been set to major_ret, which is 0 if a major
number is given. Of course it does not unregister 68 then. Consequently
when trying to load it a second time after unloading it fails, because it
has not freed the major 68.
Regards,
Stefan
next prev parent reply other threads:[~2006-05-09 17:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-29 17:25 [PATCH 2.6.17-rc3] Fix capi reload by unregistering the correct major Stefan Schweizer
2006-05-08 20:00 ` Andrew Morton
2006-05-09 17:12 ` Stefan Schweizer [this message]
2006-05-12 22:16 ` Stefan Schweizer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='e3qihe$3q2$1@sea.gmane.org' \
--to=genstef@gentoo.org \
--cc=i4ldeveloper@listserv.isdn4linux.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox