From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 15176283FDD for ; Tue, 2 Dec 2025 12:55:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764680109; cv=none; b=dSk+hBLEVh2ffJKUz+Q9cff+KzjGIg9JX63hTJEMEPzHGMSYaW+o3rDuIIN3rpAkLZmfaBIfV+IJiPVYd2jYETvNqo//GQf/tvd+W8g1pUuA1AT3nbUl3/0Jq/Gbf3+ati66iN6S5orUz3T5fnEzeKYD0L1LNAX+L0PN4MLuuNM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764680109; c=relaxed/simple; bh=IEf6MAMLo9el3TCDM1LU0L8cCge4sIKs35xb2sHnaQs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FHk/pTmYfyosVyR2OsdxUJTA/9/TGYR4310T/Wyc56AXg8Tfx3FDsGW4q6zhOC64NEec/zxoiLg8YP4iJbfIr7DlLlIuTg0Hm84XChcrJ8qp4WNibFCUca7phYMuCS9MgVjvbGN2mq1KvcuIc+CEWdqNDiY2LJYcATfuDY+vQ7g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=UPo/7qmm; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=nJxXahQs; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="UPo/7qmm"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="nJxXahQs" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1764680105; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=p8K/soAEl5Qpe2djewXayQipDTMRKNOonEUZGNR+gzM=; b=UPo/7qmm3rzWU4p/G9zab0P7KViRhHc6BgQwyIxiYnXzEcM8mKY82B1SSxMAlTCb1qnV4Y iCQhYefT5APcUIRK7wcyTCjyuSPA8KMhUr5VuoC8kAZ0S/XlJlEadvNDQbtokIYTNVhZHY 4KEO5TJJo0Rdyka0GyjJTWciHYonv6w= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-636-d85MG1EcOCG3IpJ1jON1Qw-1; Tue, 02 Dec 2025 07:55:04 -0500 X-MC-Unique: d85MG1EcOCG3IpJ1jON1Qw-1 X-Mimecast-MFC-AGG-ID: d85MG1EcOCG3IpJ1jON1Qw_1764680104 Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-4ed6466f2baso112602851cf.0 for ; Tue, 02 Dec 2025 04:55:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1764680104; x=1765284904; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=p8K/soAEl5Qpe2djewXayQipDTMRKNOonEUZGNR+gzM=; b=nJxXahQs6lqKv6leOLQPu/w6VnactF7yrmunOrhvrGXAOPgUXk+DJZBp/3bVii/vfs J4brdMKNk2n4NEw2lRw+Cb1IZj+11IwPHrG7rBOj3NXnZYKN6VNTCo5SAY1OcmIauRnK jewPItrFqPu3fPE8QFJfid+B+DsISAn+zQcZB8hl+P3J4GsJiRrI1FdLXSt+nBC9AMlP ZEl/1VysAyVr/SoCw1h1T7mqZTCLkTaEP3AlgyhHXCwYTU25toWDeATWfHNZy6yF9eLn skk65FFivGPkO4BLGghAja56NRLzWDPtUGp8VAS2jGc8iwmKdLUNyIhOW4qVy5BWZtqR GBgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764680104; x=1765284904; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=p8K/soAEl5Qpe2djewXayQipDTMRKNOonEUZGNR+gzM=; b=n7eiemn2G7p61zajADpYG8jvW8/OWClrHeMy0n8XE7lx1Jmp42zgFUgdam0LLyTj3d SCd1TVcaW7WfB5H9ZEyZkRxazibA9SgZ7Jd52NTEfVXBm/PqqWQkbRAMWUkhp7wRxGov V4Z6KIh5i58hgipArl+l+KshwVoLRh2u8K33488fO0QCT7ETmneUBVFfA6fxvO3Hjw5m cOX72cAqbsH7VmOeGYbQfhC2XPdnNIUhYDNDVsJ5PrBwr/nHNMsypz6VF3oL43Pbr4lS lQHvP5I5oT5Tm3tVd2VohvmPKZytn81XfLR+LnB9bWGVvGDQKP0WLRxMeNj0BGuSQUzi hZyA== X-Forwarded-Encrypted: i=1; AJvYcCXUDyrp1gfK+CVmwKVyaX7k+sJzfzwyU/CmchvIcD2e4EvPy72pmH+M+UMOv0YrIc0HQ/3BC7stecDDC8E=@vger.kernel.org X-Gm-Message-State: AOJu0YwNsSLwRJLDSpFV+ey++pqfcw+suwtFWmSNU6LWCjDLQz4hyoKP Rrw43GBZWl5XDUdywsYXTIkVPpXP00B76xt2Vih4Pmygit9UMylGgL2p0lS/knJB8qL3urBf9Tn JPd7dvebNzhQ/L/buiC6PeVH0+ZcAVIAt08iagIG61MZyYbrhEuw9/8L7ymqH57Tv4w== X-Gm-Gg: ASbGncsrd899GbbXZ6X/XUSue65MJyon2rfQRVhxfhQSU/VD5odfS7kYEZ2T/tuOhrE qIJ4StoRejywHz8POqNNToIqAiI03icJIXOV+MiBXAvY1xkUGasts5btzSprlDxlrGL6GCBozOP Xc/xsf6mHFLIBkGZLtXsI7/Rwg4q0O5Jzd2LG299F4stMBurCmJql4ty0s/kOm6X0UPo1Za7ghl 00cu8Pz2KuPDaeNxgXVa5VhyS50I+y0HIKoFZMhnZ/XAIk7sRfKy8oIRqvwec1OPu/RGz8Uadpq 54IWrBUMsDEZyoCXTRbc6Xnq1UI7ilKUOoYZqpsgasivJpU6I+AIzbBzUpHKLiy6bEY+RGs52By +kkyzsP3m7Q== X-Received: by 2002:ac8:5812:0:b0:4ed:685e:f3d3 with SMTP id d75a77b69052e-4ee58b3ece8mr598584781cf.81.1764680103915; Tue, 02 Dec 2025 04:55:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IHEEyTUTsKxzjm4jpwtLpYRoFXlpmTOyOsSOoys8fayyV+jq7IenUkgB2Rm759n0EVp2WsX4g== X-Received: by 2002:ac8:5812:0:b0:4ed:685e:f3d3 with SMTP id d75a77b69052e-4ee58b3ece8mr598584501cf.81.1764680103551; Tue, 02 Dec 2025 04:55:03 -0800 (PST) Received: from [10.26.1.94] ([66.187.232.136]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4efd341f2f8sm90525771cf.22.2025.12.02.04.55.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Dec 2025 04:55:03 -0800 (PST) Message-ID: Date: Tue, 2 Dec 2025 07:55:02 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] tools/power turbostat: allow turbostat to work when aperf is not available To: Len Brown Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251118155813.533424-1-darcari@redhat.com> <20251118155813.533424-4-darcari@redhat.com> <25d6584f-7763-4b6e-92da-e8f1e31ea3df@redhat.com> Content-Language: en-US From: David Arcari In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 12/1/25 3:11 PM, Len Brown wrote: > Something like this? Yes - this works. It's actually nice and clean and actually mitigates the need for patch 0001. Clearly an improvement over my patch 3. How would you like to proceed? I could resubmit a single v2 patch (with an appropriate explanation). I'd rather not attempt to solve the retry issue. It's really a second order issue and I don't think I'm the appropriate person to do that work. -DA > > diff --git a/tools/power/x86/turbostat/turbostat.c > b/tools/power/x86/turbostat/turbostat.c > index 5bc47ad5da09..4a847e7e9c65 100644 > --- a/tools/power/x86/turbostat/turbostat.c > +++ b/tools/power/x86/turbostat/turbostat.c > @@ -8530,7 +8530,7 @@ void rapl_perf_init(void) > /* Assumes msr_counter_info is populated */ > static int has_amperf_access(void) > { > - return msr_counter_arch_infos[MSR_ARCH_INFO_APERF_INDEX].present && > + return has_aperf && > msr_counter_arch_infos[MSR_ARCH_INFO_APERF_INDEX].present && > msr_counter_arch_infos[MSR_ARCH_INFO_MPERF_INDEX].present; > } > > > On Mon, Dec 1, 2025 at 2:53 PM Len Brown wrote: >> >>> ...add_msr_perf_counter() returns -1 >> >> good. and then add_msr_counter() succeeds because... >> >>> rdmsr returns zero for MSR_IA32_APERF and MSR_IA32_MPERF. >> >> Your patch is a good suggestion -- though it checks for APERF only and >> not for MPERF. >> >> We already ran CPUID and cleared has_aperf, so I'm thinking we should >> be heading this off earlier. Let me send you a test patch later today. >> >> thanks, >> Len Brown, Intel Open Source Technology Center > > >