From: <Tudor.Ambarus@microchip.com>
To: <alexandre.belloni@bootlin.com>, <emil.velikov@collabora.com>
Cc: <Nicolas.Ferre@microchip.com>, <Ludovic.Desroches@microchip.com>,
<Claudiu.Beznea@microchip.com>, <Eugen.Hristev@microchip.com>,
<Codrin.Ciubotariu@microchip.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] ARM: configs: at91: sama5: Use make savedefconfig and clean leftovers
Date: Fri, 16 Jul 2021 16:15:25 +0000 [thread overview]
Message-ID: <e424bff8-9130-b52f-1bdb-869576c3e6ac@microchip.com> (raw)
In-Reply-To: <YPGs5qGih6R9DFWG@piout.net>
On 7/16/21 6:59 PM, Alexandre Belloni wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On 16/07/2021 18:14:46+0300, Tudor Ambarus wrote:
>> Even since the addition CONFIG_VIDEO_HANTRO was set to n because
>> it did not respect the dependency chain. It doesn't respect it now
>> either, remove it.
>>
>
> Shouldn't you rather ensure it is enabled so we get it for sama5d4?
CONFIG_VIDEO_HANTRO has the following dependency chain:
Depends on: STAGING [=y] && STAGING_MEDIA [=y] && MEDIA_SUPPORT [=y] && (ARCH_MXC [=n] || ARCH_ROCKCHIP [=n] || COMPILE_TEST [=n]) && VIDEO_DEV [=y] && VIDEO_V4L2 [=y]
Maybe a better fix is to add ARCH_AT91 in the list of supported archs.
Emil, can you shed some light on this?
>
>> Fixes: a0e6830c95b7 ("ARM: configs: at91: sama5: enable the Hantro G1 engine")
>> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
>> ---
>> arch/arm/configs/sama5_defconfig | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/arch/arm/configs/sama5_defconfig b/arch/arm/configs/sama5_defconfig
>> index 17db3b3e2dd3..1ccf84091dd7 100644
>> --- a/arch/arm/configs/sama5_defconfig
>> +++ b/arch/arm/configs/sama5_defconfig
>> @@ -207,7 +207,6 @@ CONFIG_AT_HDMAC=y
>> CONFIG_AT_XDMAC=y
>> CONFIG_STAGING=y
>> CONFIG_STAGING_MEDIA=y
>> -CONFIG_VIDEO_HANTRO=m
>> # CONFIG_IOMMU_SUPPORT is not set
>> CONFIG_IIO=y
>> CONFIG_AT91_ADC=y
>> --
>> 2.25.1
>>
>
> --
> Alexandre Belloni, co-owner and COO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
>
prev parent reply other threads:[~2021-07-16 16:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-16 15:14 [PATCH 1/2] ARM: configs: at91: sama5: Use make savedefconfig and clean leftovers Tudor Ambarus
2021-07-16 15:14 ` [PATCH 2/2] ARM: configs: at91: Enable crypto software implementations Tudor Ambarus
2021-07-16 15:59 ` [PATCH 1/2] ARM: configs: at91: sama5: Use make savedefconfig and clean leftovers Alexandre Belloni
2021-07-16 16:15 ` Tudor.Ambarus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e424bff8-9130-b52f-1bdb-869576c3e6ac@microchip.com \
--to=tudor.ambarus@microchip.com \
--cc=Claudiu.Beznea@microchip.com \
--cc=Codrin.Ciubotariu@microchip.com \
--cc=Eugen.Hristev@microchip.com \
--cc=Ludovic.Desroches@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=emil.velikov@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox