Re: [PATCH v1 1/2] scsi: dt-bindings: ufs: Add vcc-voltage-level for UFS

nguyenb
2020-09-14T16:24:30Z

On 2020-09-13 02:35, Avri Altman wrote:
>>
>>
>> UFS's specifications supports a range of Vcc operating
>> voltage levels. Add documentation for the UFS's Vcc voltage
>> levels setting.
>>
>> Signed-off-by: Can Guo <cang@codeaurora.org>
>> Signed-off-by: Asutosh Das <asutoshd@codeaurora.org>
>> Signed-off-by: Bao D. Nguyen <nguyenb@codeaurora.org>
>> ---
>> Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt
>> b/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt
>> index 415ccdd..7257b32 100644
>> --- a/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt
>> +++ b/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt
>> @@ -23,6 +23,8 @@ Optional properties:
>> with "phys" attribute, provides phandle to
>> UFS PHY node
>> - vdd-hba-supply : phandle to UFS host controller supply
>> regulator node
>> - vcc-supply : phandle to VCC supply regulator node
>> +- vcc-voltage-level : specifies voltage levels for VCC supply.
> For ufs3.1+ devices
Thanks for the comments, Avri.
I am not clear what this comment means. Could you please clarify?
>
>> + Should be specified in pairs (min, max),
>> units uV.
>> - vccq-supply : phandle to VCCQ supply regulator node
>> - vccq2-supply : phandle to VCCQ2 supply regulator node
>> - vcc-supply-1p8 : For embedded UFS devices, valid VCC range
>> is 1.7-1.95V
>> --
> Why are you removing all other docs?
> They are still relevant for non ufs3.1 devices.
I did not remove anything. You may be confused by the "-" used as
listing in the original document.