From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: "Luke D. Jones" <luke@ljones.dev>
Cc: Hans de Goede <hdegoede@redhat.com>,
corentin.chary@gmail.com, platform-driver-x86@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 5/9] platform/x86: asus-wmi: store a min default for ppt options
Date: Wed, 3 Apr 2024 11:23:14 +0300 (EEST) [thread overview]
Message-ID: <e48c5226-9a25-ff24-45d8-5cc73d7d914e@linux.intel.com> (raw)
In-Reply-To: <20240403002917.2870959-6-luke@ljones.dev>
[-- Attachment #1: Type: text/plain, Size: 738 bytes --]
On Wed, 3 Apr 2024, Luke D. Jones wrote:
> Laptops with any of the ppt or nv tunables default to the minimum setting
> on boot so we can safely assume a stored value is correct.
>
> This patch adds storing of those values in the local struct, and enables
> reading of those values back. To prevent creating a series of byte holes
> in the struct the "<name>_available" bool is removed and
> `asus_sysfs_is_visible()` uses the `ASUS_WMI_DEVID_<name>` directly.
>
> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> Signed-off-by: Luke D. Jones <luke@ljones.dev>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
(I know it is already among the tags but I had not given it until now.)
--
i.
next prev parent reply other threads:[~2024-04-03 8:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-03 0:29 [PATCH v3 0/9] asus-wmi: add new features, clean up, fixes Luke D. Jones
2024-04-03 0:29 ` [PATCH v3 1/9] platform/x86: asus-wmi: add support for 2024 ROG Mini-LED Luke D. Jones
2024-04-03 7:06 ` Ilpo Järvinen
2024-04-03 0:29 ` [PATCH v3 2/9] platform/x86: asus-wmi: add support for Vivobook GPU MUX Luke D. Jones
2024-04-03 0:29 ` [PATCH v3 3/9] platform/x86: asus-wmi: add support variant of TUF RGB Luke D. Jones
2024-04-03 0:29 ` [PATCH v3 4/9] platform/x86: asus-wmi: support toggling POST sound Luke D. Jones
2024-04-03 0:29 ` [PATCH v3 5/9] platform/x86: asus-wmi: store a min default for ppt options Luke D. Jones
2024-04-03 8:23 ` Ilpo Järvinen [this message]
2024-04-03 8:24 ` Luke Jones
2024-04-03 0:29 ` [PATCH v3 6/9] platform/x86: asus-wmi: adjust formatting of ppt-<name>() functions Luke D. Jones
2024-04-03 0:29 ` [PATCH v3 7/9] platform/x86: asus-wmi: ROG Ally increase wait time, allow MCU powersave Luke D. Jones
2024-04-03 0:29 ` [PATCH v3 8/9] platform/x86: asus-wmi: Add support for " Luke D. Jones
2024-04-03 8:32 ` Ilpo Järvinen
2024-04-03 0:29 ` [PATCH v3 9/9] platform/x86: asus-wmi: cleanup main struct to avoid some holes Luke D. Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e48c5226-9a25-ff24-45d8-5cc73d7d914e@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=corentin.chary@gmail.com \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luke@ljones.dev \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox