From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-171.mta1.migadu.com (out-171.mta1.migadu.com [95.215.58.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A54DD1474DA for ; Tue, 21 Jan 2025 13:48:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737467311; cv=none; b=CdA3ycjlnqEfIk/lXeWiDAe74/0nHiT1J3GpE8JytQsswRfxgTd9kJo6pffB0UokZkLxEcVVH1LfqPSIH0ZkxKeqxnUomWgpzwyWjjdYUBx4Ok9x3EV11aTy2aWHBRpevqhC/7OHHKlbvrlF6TeXi445rDFj7ySNStOC0LH2+Iw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737467311; c=relaxed/simple; bh=A1veeuuDV4mUrpjQBHR1woepVyEYnaVMB8tp7YWwLX8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Jr/pU96Ap4Dzkn9DNn+qFFAmm670mOdTZN6mK3XTIB/qhhGyWn7KyM3z8V6ZTUf7kWM2sbca+mOqXaZRfVqgxNHPS4VVRETQSuYT/onDqPp6XUMvhtKTOcxD/SLKqX68ZyuJVN5Fw25cM9eq3Bo7wrN+g3/c3QfWaMsOB7V9iMc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=MD8geIto; arc=none smtp.client-ip=95.215.58.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="MD8geIto" Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1737467307; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=A1veeuuDV4mUrpjQBHR1woepVyEYnaVMB8tp7YWwLX8=; b=MD8geItoywKwvi410Xh5hTFCZ+4Z/GAKCp/KyV1RltaFDmUNxW4MiOugDF7szcAclFwLK3 ofTtKmkpkINwwMfGyntCd6SSvDdJrWqe4K42C70UXeeWJaCxsGWr8pdbY6xfcCRJpEFQGp b7bzRTEB7wXCImDbOfbRutZRXOGAoAE= Date: Tue, 21 Jan 2025 21:47:32 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH] net: stmmac: dwmac-loongson: Add fix_soc_reset function To: Huacai Chen , Qunqin Zhao Cc: kuba@kernel.org, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, fancer.lancer@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250121082536.11752-1-zhaoqunqin@loongson.cn> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Yanteng Si In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT 在 1/21/25 17:29, Huacai Chen 写道: > Hi, Qunqin, > > The patch itself looks good to me, but something can be improved. > 1. The title can be "net: stmmac: dwmac-loongson: Add fix_soc_reset() callback" > 2. You lack a "." at the end of the commit message. > 3. Add a "Cc: stable@vger.kernel.org" because it is needed to backport > to 6.12/6.13. Then we also need to have a fixes tag. Thanks, Yanteng