From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Jiri Slaby <jirislaby@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-serial <linux-serial@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/3] serial: Add uart_xmit_advance() + fixes part (of a larger patch series)
Date: Mon, 29 Aug 2022 10:54:43 +0300 (EEST) [thread overview]
Message-ID: <e4a25dfa-a2f9-5165-2f39-1730476c5220@linux.intel.com> (raw)
In-Reply-To: <1a05800e-a3c2-12f3-135e-b81a283d71a2@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 431 bytes --]
On Mon, 29 Aug 2022, Jiri Slaby wrote:
> On 29. 08. 22, 9:41, Ilpo Järvinen wrote:> Looking into your patches, they
> also seemed to lack that> icount.tx++ thing.
>
> Perhaps, you only overlooked it?
>
> + for (; (for_test) && (!tx_ready || tx_ready(port));
> + (for_post), port->icount.tx++) {
Ah, yes, I did (and its placement at the end of a multi-line for() didn't
help that much either for pick it up :-)).
--
i.
prev parent reply other threads:[~2022-08-29 7:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-25 9:17 [PATCH 0/3] serial: Add uart_xmit_advance() + fixes part (of a larger patch series) Ilpo Järvinen
2022-08-25 9:17 ` [PATCH 1/3] serial: Create uart_xmit_advance() Ilpo Järvinen
2022-08-30 12:27 ` Greg Kroah-Hartman
2022-08-30 12:38 ` Andy Shevchenko
2022-08-30 12:48 ` Greg Kroah-Hartman
2022-08-30 12:53 ` Andy Shevchenko
2022-08-25 9:17 ` [PATCH 2/3] serial: tegra: Use uart_xmit_advance(), fixes icount.tx accounting Ilpo Järvinen
2022-08-25 9:17 ` [PATCH 3/3] serial: tegra-tcu: " Ilpo Järvinen
2022-08-26 16:03 ` [PATCH 0/3] serial: Add uart_xmit_advance() + fixes part (of a larger patch series) Andy Shevchenko
2022-08-29 7:23 ` Jiri Slaby
2022-08-29 7:41 ` Ilpo Järvinen
2022-08-29 7:50 ` Jiri Slaby
2022-08-29 7:54 ` Ilpo Järvinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4a25dfa-a2f9-5165-2f39-1730476c5220@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox