From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-172.mta0.migadu.com (out-172.mta0.migadu.com [91.218.175.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B050A2DE1FC for ; Mon, 21 Jul 2025 14:29:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753108181; cv=none; b=tsQz+Rvbs8lsQcIKeDkM40IT73QnAngzUhhuO0RUYyjTq6fNIXVgF/26DQRv7NuQgnJCKXpZlbN6VqCogrnwJpG5viDUjtP99TVdx+2GslluBBTV4Cj5liBQnyHN23rc4WkweVrm94TgE9shLUUYNbhfC6wOBgst1ZnCK0/4EXA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753108181; c=relaxed/simple; bh=1qRXyIN+3+TFXy30A4Y/3F/v4Qgs/YpJ1iDImQB/Tcw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dJ6sYnre2YJC+ZH+B9I07Ml0bi7nodiR5IPkeh/rEL7bomelpCmLkEx6CKKcFOUTj9nrW9jhSdHTUpO5A2cBdQOHHfX+scP4naEtHwzQnHan8OS79q8psBP35lJyhGm/lK8ipyqtJiSDk4A9iAuWx3YeFDIomSE4PGi2Vx3KRWg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=gGKh0sBy; arc=none smtp.client-ip=91.218.175.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="gGKh0sBy" Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1753108177; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZEUThsSpCMUbwMYhQ5KetKy8D1sXeNWxSdmUlfQSjfQ=; b=gGKh0sByoEfCusDPYDneYqYDDtCK981D27SuDhdK1Ixp787h2480p0CgfM/vjALi68PWt0 zP91EVutwm8w0xObTCjpJ2olmJx3SK3q8+WFB+Fep0wyQv4Fx+QwckhdeTVMgINSWDoBq0 69KICTRAgIckMRGVMUmR9aWZqsf9IvY= Date: Mon, 21 Jul 2025 10:29:32 -0400 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH net v2 1/4] auxiliary: Support hexadecimal ids To: Leon Romanovsky Cc: Greg Kroah-Hartman , Radhey Shyam Pandey , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, Dave Ertman , Saravana Kannan , linux-kernel@vger.kernel.org, Michal Simek , linux-arm-kernel@lists.infradead.org, Ira Weiny References: <20250716000110.2267189-1-sean.anderson@linux.dev> <20250716000110.2267189-2-sean.anderson@linux.dev> <2025071637-doubling-subject-25de@gregkh> <719ff2ee-67e3-4df1-9cec-2d9587c681be@linux.dev> <2025071747-icing-issuing-b62a@gregkh> <5d8205e1-b384-446b-822a-b5737ea7bd6c@linux.dev> <2025071736-viscous-entertain-ff6c@gregkh> <03e04d98-e5eb-41c0-8407-23cccd578dbe@linux.dev> <2025071726-ramp-friend-a3e5@gregkh> <5ee4bac4-957b-481a-8608-15886da458c2@linux.dev> <20250720081705.GE402218@unreal> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Sean Anderson In-Reply-To: <20250720081705.GE402218@unreal> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 7/20/25 04:17, Leon Romanovsky wrote: > On Thu, Jul 17, 2025 at 01:12:08PM -0400, Sean Anderson wrote: >> On 7/17/25 12:33, Greg Kroah-Hartman wrote: > > <...> > >> Anyway, if you really think ids should be random or whatever, why not >> just ida_alloc one in axiliary_device_init and ignore whatever's >> provided? I'd say around half the auxiliary drivers just use 0 (or some >> other constant), which is just as deterministic as using the device >> address. > > I would say that auxiliary bus is not right fit for such devices. This > bus was introduced for more complex devices, like the one who has their > own ida_alloc logic. I'd say that around 2/3 of the auxiliary drivers that have non-constant ids use ida_alloc solely for the auxiliary bus and for no other purpose. I don't think that's the kind of complexity you're referring to. >> Another third use ida_alloc (or xa_alloc) so all that could be >> removed. > > These ID numbers need to be per-device. Why? They are arbitrary with no semantic meaning, right? --Sean