Re: [PATCH 00/15] [Set 2] Rid W=1 warnings from ATA

Lee Jones
2021-03-30T13:21:51Z

On Thu, 18 Mar 2021, Lee Jones wrote:

> This set is part of a larger effort attempting to clean-up W=1
> kernel builds, which are currently overwhelmingly riddled with
> niggly little warnings.
>
> This is set 2 out of 2 sets required.
>
> Lee Jones (15):
> ata: pata_pdc202xx_old: Fix some incorrectly named functions
> ata: pata_sil680: Add some missing function parameter docs
> ata: pata_sis: Remove superfluous param description and supply another
> ata: pata_triflex: Repair some misnamed functions and fix some param
> descriptions
> ata: pata_it821x: Fix possible doc-rotted function names
> ata: pata_via: Fix a kernel-doc formatting issue
> ata: pata_piccolo: 'ata_tosh_init()' is misnamed in its header
> ata: pata_sl82c105: Fix potential doc-rot
> ata: pata_opti: Fix spelling issue of 'val' in 'opti_write_reg()'
> ata: ata_generic: Fix misspelling of 'ata_generic_init_one()'
> ata: pata_legacy: Repair a couple kernel-doc problems
> ata: pata_cs5530: Fix misspelling of 'cs5530_init_one()'s 'pdev' param
> ata: sata_mv: Fix misnaming of 'mv_bmdma_stop()'
> ata: libata-acpi: Fix function name and provide description for
> 'prev_gtf'
> ata: pata_acpi: Fix some incorrect function param descriptions

Would you like me to resubmit these?

> drivers/ata/ata_generic.c | 2 +-
> drivers/ata/libata-acpi.c | 3 ++-
> drivers/ata/pata_acpi.c | 6 +++---
> drivers/ata/pata_cs5530.c | 2 +-
> drivers/ata/pata_it821x.c | 4 ++--
> drivers/ata/pata_legacy.c | 8 ++++----
> drivers/ata/pata_opti.c | 2 +-
> drivers/ata/pata_pdc202xx_old.c | 4 ++--
> drivers/ata/pata_piccolo.c | 2 +-
> drivers/ata/pata_sil680.c | 2 ++
> drivers/ata/pata_sis.c | 2 +-
> drivers/ata/pata_sl82c105.c | 2 +-
> drivers/ata/pata_triflex.c | 7 +++----
> drivers/ata/pata_via.c | 2 +-
> drivers/ata/sata_mv.c | 2 +-
> 15 files changed, 26 insertions(+), 24 deletions(-)
>
> Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
> Cc: ALWAYS copy <linux-ide@vger.kernel.org>
> Cc: Andre Hedrick <andre@linux-ide.org>
> Cc: Colten Edwards <pje120@cs.usask.ca>
> Cc: Hat Inc <alan@redhat.com>
> Cc: Jan Harkes <jaharkes@cwi.nl>
> Cc: Jaromir Koutek <miri@punknet.cz>
> Cc: Jens Axboe <axboe@kernel.dk>
> Cc: "L.C. Chang" <lcchang@sis.com.tw>
> Cc: linux-ide@vger.kernel.org
> Cc: Lionel Bouton <Lionel.Bouton@inet6.fr>
> Cc: Mark Lord <mlord@pobox.com>
> Cc: Red Hat <alan@redhat.com>
> Cc: Samuel Thibault <samuel.thibault@ens-lyon.org>
> Cc: Torben Mathiasen <torben.mathiasen@hp.com>
> Cc: Vojtech Pavlik <vojtech@suse.cz>

--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog