linux-next: build warning after merge of the iommu tree

linux-next: build warning after merge of the iommu tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1194 bytes --]

Hi Joerg,

After merging the iommu tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

In file included from include/linux/bitmap.h:10,
                 from drivers/iommu/intel-iommu.c:24:
drivers/iommu/intel-iommu.c: In function 'iommu_calculate_agaw':
include/linux/kernel.h:845:29: warning: comparison of distinct pointer types lacks a cast
   (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
                             ^~
include/linux/kernel.h:859:4: note: in expansion of macro '__typecheck'
   (__typecheck(x, y) && __no_side_effects(x, y))
    ^~~~~~~~~~~
include/linux/kernel.h:869:24: note: in expansion of macro '__safe_cmp'
  __builtin_choose_expr(__safe_cmp(x, y), \
                        ^~~~~~~~~~
include/linux/kernel.h:878:19: note: in expansion of macro '__careful_cmp'
 #define min(x, y) __careful_cmp(x, y, <)
                   ^~~~~~~~~~~~~
drivers/iommu/intel-iommu.c:668:9: note: in expansion of macro 'min'
  mgaw = min(cap_mgaw(iommu->cap), DEFAULT_DOMAIN_ADDRESS_WIDTH);
         ^~~

Introduced by commit

  248808a0fad0 ("iommu/vt-d: Respect max guest address width in agaw")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the iommu tree

[Joerg Roedel]

Hi Stephen,

On Thu, Nov 08, 2018 at 12:39:38PM +1100, Stephen Rothwell wrote:
> Introduced by commit
> 
>   248808a0fad0 ("iommu/vt-d: Respect max guest address width in agaw")

Thanks for the report! That commit was revoked by the submitter and is
now removed from the tree. The warning should disappear in the next
merge.

Regards,

	Joerg

linux-next: build warning after merge of the iommu tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 570 bytes --]

Hi Joerg,

After merging the iommu tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

In file included from drivers/pci/pci.c:32:
include/linux/pci-ats.h:70:12: warning: 'pci_prg_resp_pasid_required' defined but not used [-Wunused-function]
 static int pci_prg_resp_pasid_required(struct pci_dev *pdev)
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~

Introduced by commit

  e5567f5f6762 ("PCI/ATS: Add pci_prg_resp_pasid_required() interface.")

The non CONFIG_PCI_PASID version needs an "inline".

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the iommu tree

[sathyanarayanan kuppuswamy]

Hi,

On 2/26/19 6:20 PM, Stephen Rothwell wrote:
> Hi Joerg,
>
> After merging the iommu tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
>
> In file included from drivers/pci/pci.c:32:
> include/linux/pci-ats.h:70:12: warning: 'pci_prg_resp_pasid_required' defined but not used [-Wunused-function]
>   static int pci_prg_resp_pasid_required(struct pci_dev *pdev)
>              ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Introduced by commit
>
>    e5567f5f6762 ("PCI/ATS: Add pci_prg_resp_pasid_required() interface.")
>
> The non CONFIG_PCI_PASID version needs an "inline".
I can submit the fix, but do we need a new patch to fix it or the 
original patch can be updated ?
>
-- 
Sathyanarayanan Kuppuswamy
Linux kernel developer

[PATCH v1 1/1] PCI/ATS: Add inline to pci_prg_resp_pasid_required()

[Kuppuswamy Sathyanarayanan]

Fix unused function warning when compiled with CONFIG_PCI_PASID
disabled.

Fixes: e5567f5f6762 ("PCI/ATS: Add pci_prg_resp_pasid_required() interface.")
Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
---
 include/linux/pci-ats.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/pci-ats.h b/include/linux/pci-ats.h
index facfd6a18fe1..1ebb88e7c184 100644
--- a/include/linux/pci-ats.h
+++ b/include/linux/pci-ats.h
@@ -67,7 +67,7 @@ static inline int pci_max_pasids(struct pci_dev *pdev)
 	return -EINVAL;
 }
 
-static int pci_prg_resp_pasid_required(struct pci_dev *pdev)
+static inline int pci_prg_resp_pasid_required(struct pci_dev *pdev)
 {
 	return 0;
 }
-- 
2.20.1

linux-next: build warning after merge of the iommu tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 615 bytes --]

Hi all,

After merging the iommu tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

WARNING: modpost: vmlinux.o(.text.unlikely+0xddf06): Section mismatch in reference from the function detect_ivrs() to the variable .init.data:amd_iommu_force_enable
The function detect_ivrs() references
the variable __initdata amd_iommu_force_enable.
This is often because detect_ivrs lacks a __initdata 
annotation or the annotation of amd_iommu_force_enable is wrong.

Introduced by commit

  b1e650db2cc4 ("iommu/amd: Add amd_iommu=force_enable option")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the iommu tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 376 bytes --]

Hi all,

After merging the iommu tree, today's linux-next build (htmldocs)
produced this warning:

Documentation/userspace-api/index.rst:42: WARNING: toctree contains reference to nonexisting document 'userspace-api/iommu'

Introduced by commit

  d926e7c04843 ("docs: iommu: Remove outdated Documentation/userspace-api/iommu.rst")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the iommu tree

[Will Deacon]

On Tue, Jul 09, 2024 at 07:06:13PM +1000, Stephen Rothwell wrote:
> Hi all,

Welcome back!

> After merging the iommu tree, today's linux-next build (htmldocs)
> produced this warning:
> 
> Documentation/userspace-api/index.rst:42: WARNING: toctree contains reference to nonexisting document 'userspace-api/iommu'
> 
> Introduced by commit
> 
>   d926e7c04843 ("docs: iommu: Remove outdated Documentation/userspace-api/iommu.rst")

Cheers, I'll fold the fix into that change.

Will

linux-next: build warning after merge of the iommu tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 592 bytes --]

Hi all,

After merging the iommu tree, today's linux-next build (htmldocs)
produced this warning:

Documentation/ABI/testing/debugfs-amd-iommu:31: ERROR: Unexpected indentation. [docutils]
Documentation/ABI/testing/debugfs-amd-iommu:31: WARNING: Block quote ends without a blank line; unexpected unindent. [docutils]
Documentation/ABI/testing/debugfs-amd-iommu:31: WARNING: Block quote ends without a blank line; unexpected unindent. [docutils]

Introduced by commit

  39215bb3b0d9 ("iommu/amd: Add documentation for AMD IOMMU debugfs support")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the iommu tree

[Will Deacon]

On Wed, Jul 16, 2025 at 08:42:07PM +1000, Stephen Rothwell wrote:
> After merging the iommu tree, today's linux-next build (htmldocs)
> produced this warning:
> 
> Documentation/ABI/testing/debugfs-amd-iommu:31: ERROR: Unexpected indentation. [docutils]
> Documentation/ABI/testing/debugfs-amd-iommu:31: WARNING: Block quote ends without a blank line; unexpected unindent. [docutils]
> Documentation/ABI/testing/debugfs-amd-iommu:31: WARNING: Block quote ends without a blank line; unexpected unindent. [docutils]
> 
> Introduced by commit
> 
>   39215bb3b0d9 ("iommu/amd: Add documentation for AMD IOMMU debugfs support")

Thanks, Stephen. That should be fixed now.

Will