From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E5AD149C69 for ; Thu, 2 Jan 2025 11:33:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735817596; cv=none; b=ECnhSERJVURW01Cq+K74XGbQyJsZB8rdetkT+1Izfj3wc3OWLB+HgdSXxRLeuDoOef9ImcZmlm3brRAZCUyQiDN4EYJBrWV8ceIba8OGMptQmbn618yT7/ESCGLr1YoSf4SzLAXaKBo8vpC8fvadHY07eprVpsfv3C2VnVymCnc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735817596; c=relaxed/simple; bh=WXu7iYUVtxd4Jvxnu/vc//Z4knpTKknJj09R2zxYpfY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Cu0JQqWbGngX1YYO8rrguFAkvwRm5U9igI+tqFuBDzEYnPx4LCyMZ/IGdk9J+n8kZ4KNnl7A2DFANSvzowwddOzbn4J+RcnuQ+3Aqdw3oSJKRGZ4qkc4pIRTW4ZJZzQYTiorOL2zobhXtlGQmQCbFoXhJKG7Xahhk+fM5KbQ+VE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=b0uIj33l; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="b0uIj33l" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1735817594; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=mLSWWA52yT997AEOuJwytCzUqDcxJEdXu9wbmXsgczE=; b=b0uIj33ly68ZuIPH7wegCTxFauAI/gHUPYUpjdk5562c/A5B5TdwG5ixgZDjTI0aE+mvvO lvwDVWeGU9CZIyhUvp5JeF3nAtcIIlvdfBCDdvJYX9A2EO4f/BA3gzOQmuYmVFdq6+YjuV rj2EllikVgPgV5jp54iRGVy1QmhLvDw= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-571-WapiVWvHPECUh5Gzy96otg-1; Thu, 02 Jan 2025 06:33:12 -0500 X-MC-Unique: WapiVWvHPECUh5Gzy96otg-1 X-Mimecast-MFC-AGG-ID: WapiVWvHPECUh5Gzy96otg Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-43625ceae52so62707825e9.0 for ; Thu, 02 Jan 2025 03:33:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735817591; x=1736422391; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=mLSWWA52yT997AEOuJwytCzUqDcxJEdXu9wbmXsgczE=; b=DbPT6asMmp5vkU1xyCnrv/9rmCm5OofbdLPlc82XJ3ppzmd7rnD3eLrhzAMmuOhFRI YT2d/NHxGqrQSaBOD1fil03rBKEdOXEvf6w345jSuKyWP2xwzKlrwXY2EYaX1DP+xa5Q DpO2vH/TJtLw4SDMY1/9eqD5ibJHV+yxLHhlYQhEke9K28GYSdAfZ2F94mlUURyOCaqH MbZWQFbsHLIuGuXxYfgUjtwyZQS47KsNjXyQIH0Y0Bhq7DluGpc9UgNpGh7k0xtoXTHV hgrVdHfHwW/l3uENrYPN0+12Nty+B67UNNpTzBlZ6agnau3QXXCa74gxCyG3zezE+7q4 snrA== X-Forwarded-Encrypted: i=1; AJvYcCUG/XCvE16hAEU5htkIDPwtIjhrHke+uHKomrSm56vjAOriDdnuTHmGZCaCyrSeBe5NeL7i63CL0XZ8sPw=@vger.kernel.org X-Gm-Message-State: AOJu0YzHoBAxIBkiXOxxV2lDutUqzZh6e3NTk1PPp4Bfz07b4jRJyB9F 8Qa8KCCaQTWWrmGVRAq+65rJ4YvmVth2I7XgETMGIOB8mxvNays3Gys73WXd6UN+MhrVeYfsAdh QGqw5MxTca77mn73IObgWHAtIEwmsH+0jM4YJNlm9BDWqi9StK4Tx/HRuKJG9fQ== X-Gm-Gg: ASbGncsizwCJf3l09Up1k4j2M3Mi+UiGvvyh3tRJFynrXncrwvrQ7GNOeyJ0hnKPohm 1AEyATjoM1AF1pdbWLZeuosKg8lXKIasrFjY+5v2EpQ0h4ZFMwRsQkR544/85ZlJME1XWpY6sD9 plr16RkMcuAh5tzrVAi/bZKiNPNhYu+tsBe7qPwDiSahA6QYc2JPXKG+jboM8AwPnk7/w4ijw/Q FWkON8KNd8Iv5jMYiBJlmuAt99t9Akfpi7JEkVa6GYwz8BaZU5qCXKw+cGCPySIxsIIt3Wnw5xI ZORiiYYa3PGLe1TZgbb+Qy6dmaE/qvXTVibhPOdNZpPegDf6xphj3lnn/UVHGhEb+VgCOODTbho T+w5iE3Et X-Received: by 2002:a05:600c:5112:b0:434:faa9:5266 with SMTP id 5b1f17b1804b1-436c2b5b491mr2644435e9.13.1735817591012; Thu, 02 Jan 2025 03:33:11 -0800 (PST) X-Google-Smtp-Source: AGHT+IHTX3tPQ+BahOJXy8WMYJ9SLwiimVpaV1P8aZElUVdfYcjhCrwqjTDuGv9rburyVFkE2PoIAQ== X-Received: by 2002:a05:600c:5112:b0:434:faa9:5266 with SMTP id 5b1f17b1804b1-436c2b5b491mr2644055e9.13.1735817590505; Thu, 02 Jan 2025 03:33:10 -0800 (PST) Received: from ?IPV6:2003:cb:c735:9400:f91f:1f24:e403:81fe? (p200300cbc7359400f91f1f24e40381fe.dip0.t-ipconnect.de. [2003:cb:c735:9400:f91f:1f24:e403:81fe]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43656b3b214sm489238855e9.28.2025.01.02.03.33.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jan 2025 03:33:09 -0800 (PST) Message-ID: Date: Thu, 2 Jan 2025 12:33:05 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 09/12] khugepaged: Introduce vma_collapse_anon_folio() To: Dev Jain , akpm@linux-foundation.org, willy@infradead.org, kirill.shutemov@linux.intel.com Cc: ryan.roberts@arm.com, anshuman.khandual@arm.com, catalin.marinas@arm.com, cl@gentwo.org, vbabka@suse.cz, mhocko@suse.com, apopple@nvidia.com, dave.hansen@linux.intel.com, will@kernel.org, baohua@kernel.org, jack@suse.cz, srivatsa@csail.mit.edu, haowenchao22@gmail.com, hughd@google.com, aneesh.kumar@kernel.org, yang@os.amperecomputing.com, peterx@redhat.com, ioworker0@gmail.com, wangkefeng.wang@huawei.com, ziy@nvidia.com, jglisse@google.com, surenb@google.com, vishal.moola@gmail.com, zokeefe@google.com, zhengqi.arch@bytedance.com, jhubbard@nvidia.com, 21cnbao@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20241216165105.56185-1-dev.jain@arm.com> <20241216165105.56185-10-dev.jain@arm.com> <2215dd8e-233a-427b-b15c-a2ffbce8f46d@redhat.com> <28013908-65d8-462e-b975-cd0f63d226b1@arm.com> <0368f4f2-cb0f-4633-a86d-5c3f75839b4e@redhat.com> <8d752d25-b9b2-4bf9-9a81-254aeb3ab0f6@arm.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <8d752d25-b9b2-4bf9-9a81-254aeb3ab0f6@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit >>> >>> When having to back-off (restore original PTEs), or for copying, >>> you'll likely need access to the original PTEs, which were already >>> cleared. So likely you need a temporary copy of the original PTEs >>> somehow. >>> >>> That's why temporarily clearing the PMD und mmap write lock is easier >>> to implement, at the cost of requiring the mmap lock in write mode >>> like PMD collapse. > > Why do I need to clear the PMD if I am taking the mmap_write_lock() and > operating only on the PTE? One approach I proposed to Nico (and I think he has a prototype) is: a) Take all locks like we do today (mmap in write, vma in write, rmap in write) After this step, no "ordinary" page table walkers can run anymore b) Clear the PMD entry and flush the TLB like we do today After this step, neither the CPU can read/write folios nor GUP-fast can run. The PTE table is completely isolated. c) Now we can work on the (temporarily cleared) PTE table as we please: isolate folios, lock them, ... without clearing the PTE entries, just like we do today. d) Allocate the new folios (we don't have to hold any spinlocks), copy + replace the affected PTE entries in the isolated PTE table. Similar to what we do today, except that we don't clear PTEs but instead clear+reset. e) Unlock+un-isolate + unref the collapsed folios like we do today. f) Re-map the PTE-table, like we do today when collapse would have failed. Of course, after taking all locks we have to re-verify that there is something to collapse (e.g., in d) we also have to check for unexpected folio references). The backup path is easy: remap the PTE table as no PTE entries were touched just yet. Observe that many things are "like we do today". As soon as we go to read locks + PTE locks, it all gets more complicated to get it right. Not that it cannot be done, but the above is IMHO a lot simpler to get right. -- Cheers, David / dhildenb