From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752909AbdLMNMq (ORCPT ); Wed, 13 Dec 2017 08:12:46 -0500 Received: from mout.web.de ([212.227.15.3]:60478 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751910AbdLMNMp (ORCPT ); Wed, 13 Dec 2017 08:12:45 -0500 Subject: [PATCH 2/4] staging/wlan-ng/prism2fw: Use a known error code after a failed kzalloc() in mkimage() From: SF Markus Elfring To: devel@driverdev.osuosl.org, Greg Kroah-Hartman , Maciek Borzecki , Simo Koskinen , Thibaut Sautereau Cc: LKML , kernel-janitors@vger.kernel.org References: <3599ae76-1aa8-4b6a-bf31-90e467759629@users.sourceforge.net> Message-ID: Date: Wed, 13 Dec 2017 14:12:41 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <3599ae76-1aa8-4b6a-bf31-90e467759629@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:VT+5I+aI6+o48gdR9Qak+mgVywYxz3S1XOWX9YrGOoU42ReGwk9 e7Zfu+Vdh6EuJWrE/ZlCIMUOfKUQ4TMNh6IG/dc7qn6KT+D9OHB8nKVtF1E5DEi3IealH9l kEZrIfvqphbaycEmE1/EwaYTCyxzp5Udge1cxJMZn+XtoaHD9iRm3PxpSEwK3EbAQLgnGwi yn2iIBOESR8QOlEbkAWrA== X-UI-Out-Filterresults: notjunk:1;V01:K0:dyNzJ0Akj10=:ivXt0Cvt1OFjnbhNWLJT5R MXcGAZlDyrGim1R/GjNgGxQ7Xk0HrXdaqVrBGYzf8nZoPMGbKSPfaOQTwAl5KSHz6gnQeMEhw dHTS8DOBzYYo39ApWlwkfS+m3hZ2zUNgezRfg5w6Rl4+iTglw+7Q5CDfaA7KBQ5bn4BYmKhcZ gDXxZiP0bnA65SD9N+z3nSRuOkRcP07G1SVahIDmGpaJm5mn61HZppVRITL/NpPAsehsGJoR2 tiR/mUkSQk4Js0L+TAydOKOXtfEzqsVVbT3HyJDkUsbzTGIK/gqYkBB/kHJHaeMbQt3JpFjH8 +zOv88C0hzSutCMK9GbkhNd0f1ILdqyaTx5oeslCK4ZMooTBpRpYqN3Si/Fms+WZd9IIxAxhQ XZ+6duWQPFT5HxWzSiHAtnIfZtcHMTBMk/e0KYu8dCEjTW9jpEajuToNt7gHVDYUXCcWu+hT1 7rCDgysUu33cdhYtxDvyfx9FXs5pJp/xz23VqwCehISuSrHsHSqY4UQHu3ODv1FNZsIO9YflY TJHbLMfrVz3L6i6JBsqymbeoqAVsXOnhHJMPsJdJI8rv+ZBi77V31jfiKrPrVKSqOPa1Wa9cN K8XzUwJU9fqKGocxxx5W14H1WNoithLOxX/OjgmvpilA5UZ79I7ZiXrXQwKnq4C0EFhrO5Tjl a3RTP0oqR1ba3qtoAUr8wdlZj46qZ3fW1fFzjVDlyk0vINHiJzmHxCfA4JCm5OMagrQ5W1h4+ t/XVzeFEdS4qVhAifVdwC5y0FUVolyYzTMwBXkboeM75+v6ervl7lfkDfIx7zD2sCrHW9thnT /BZ9ztFuYV+mfK2zz2YWZkwH6mtu6rsTCmqnegJK+ikwKwYKrk= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Wed, 13 Dec 2017 13:20:10 +0100 Make a memory allocation failure clearer by using the error code "-ENOMEM" (instead of the constant "1") in this function. Signed-off-by: Markus Elfring --- drivers/staging/wlan-ng/prism2fw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wlan-ng/prism2fw.c b/drivers/staging/wlan-ng/prism2fw.c index 6888d1b093fa..efca9108dad8 100644 --- a/drivers/staging/wlan-ng/prism2fw.c +++ b/drivers/staging/wlan-ng/prism2fw.c @@ -558,7 +558,7 @@ static int mkimage(struct imgchunk *clist, unsigned int *ccnt) for (i = 0; i < *ccnt; i++) { clist[i].data = kzalloc(clist[i].len, GFP_KERNEL); if (!clist[i].data) - return 1; + return -ENOMEM; pr_debug("chunk[%d]: addr=0x%06x len=%d\n", i, clist[i].addr, clist[i].len); -- 2.15.1