From: Stephen Boyd <sboyd@kernel.org>
To: Joe Hattori <joe@pf.is.s.u-tokyo.ac.jp>,
Konrad Dybcio <konradybcio@kernel.org>,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Cc: Marijn Suijten <marijn.suijten@somainline.org>,
linux-kernel@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@oss.qualcomm.com>,
Abel Vesa <abel.vesa@linaro.org>,
Johan Hovold <johan+linaro@kernel.org>,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Subject: Re: [PATCH] spmi: Fix controller->node != parent->node breakage
Date: Mon, 13 Jan 2025 11:16:41 -0800 [thread overview]
Message-ID: <e4feb21891b899a189fe51362bba7f89.sboyd@kernel.org> (raw)
In-Reply-To: <20250111-topic-spmi_node_breakage-v1-1-3f60111a1d19@oss.qualcomm.com>
Quoting Konrad Dybcio (2025-01-11 03:21:00)
> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>
> On some platforms, like recent Qualcomm SoCs with multi-bus SPMI
> arbiters, controller->node must be assigned to the individual buses'
> subnodes, as the slave devices are children of these, like so:
>
> arbiter@c400000
> spmi@c42d000
> pmic@0
>
> spmi@c432000
> pmic@0
>
> The commit referenced in Fixes changed that assignment, such that
> spmi_controller_alloc() always assumes the PMICs come directly under
> the arbiter node (which is true when there's only a single bus per
> controller).
>
> Make controller->node specifiable to both benefit from Joe's refcount
> improvements and un-break the aforementioned platforms.
>
> Fixes: 821b07853e32 ("spmi: hisi-spmi-controller: manage the OF node reference in device initialization and cleanup")
I'll drop that patch. It sounds like it's not ready.
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
prev parent reply other threads:[~2025-01-13 19:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-11 11:21 [PATCH] spmi: Fix controller->node != parent->node breakage Konrad Dybcio
2025-01-12 2:26 ` kernel test robot
2025-01-12 3:48 ` kernel test robot
2025-01-13 19:16 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4feb21891b899a189fe51362bba7f89.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=abel.vesa@linaro.org \
--cc=bjorn.andersson@oss.qualcomm.com \
--cc=joe@pf.is.s.u-tokyo.ac.jp \
--cc=johan+linaro@kernel.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=mchehab+huawei@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox